Differential D43

INP-1409 - Don't calculate search relevance twice, when searching for one word only
ClosedPublic
Actions

Authored by glebs on Feb 20 2015, 6:39 AM.

Details

Reviewers

alex

Commits

rINP16148: Fixes INP-1409 - Double weight in search relevance calculation

Test Plan

Diff Detail

Repository

rINP In-Portal

Branch

/w/in-portal.full/branches/5.2.x

Lint

Lint OK

Unit

No Unit Test Coverage

Event Timeline

glebs updated this revision to Diff 105.Feb 20 2015, 6:39 AM

glebs retitled this revision from to INP-1409 Double weight in search relevance calculation.

glebs updated this object.

glebs edited the test plan for this revision. (Show Details)

glebs added 1 JIRA issue(s): INP-1409.

Herald added a reviewer: alex. · View Herald TranscriptFeb 20 2015, 6:39 AM

Need to think about what are pros/cons of each approach described as inline comment below.

core/kernel/db/cat_event_handler.php
1322–1325	NOTE: Same applies to changes in other file. The `$positive_words` are basically all keywords, that don't have `-` (minus sign) in front of them. So the only case, when we won't have them is with search keyword like this: `-"don't include me"`, which will find all records that don't include that text. What I'm unsure about is, what weight to use (`$weight` or `$weight_sum`), when we have 1 positive keyword. // cc: @dmitry

This revision now requires changes to proceed.Feb 20 2015, 7:40 AM

alex added inline comments.Feb 20 2015, 10:10 AM

core/kernel/db/cat_event_handler.php
1322–1325	@dmitry confirmed, that we: should remove `if ( count($positive_words) > 1 ) {` from his current location add `if ( count($positive_words) > 1 ) {` around 1233 line (where `$weight_sum` is used)

Change weight, applied to search by one word

alex accepted this revision.Feb 20 2015, 10:38 AM

alex edited edge metadata.

This revision is now accepted and ready to land.Feb 20 2015, 10:38 AM

Closed by commit rINP16148: Fixes INP-1409 - Double weight in search relevance calculation (authored by alex). · Explain WhyMar 21 2015, 7:07 AM

This revision was automatically updated to reflect the committed changes.

alex edited the test plan for this revision. (Show Details)Mar 10 2016, 6:45 AM

alex edited edge metadata.

alex added a project: Restricted Project.

alex retitled this revision from INP-1409 Double weight in search relevance calculation to INP-1409 - Don't calculate search relevance twice, when searching for one word only.Mar 27 2016, 6:10 AM

Revision Contents
Changeset List

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	105	16128		Feb 20 2015, 6:39 AM	★	★
Diff 2	106	16128	Change weight, applied to search by one word	Feb 20 2015, 10:30 AM	★	★
Diff 3	136	16142	Commit rINP16148	Mar 21 2015, 7:07 AM	★	★

			Path	Packages
M			core/kernel/db/cat_event_handler.php (7 lines)
M			core/units/categories/categories_event_handler.php (7 lines)

INP-1409 - Don't calculate search relevance twice, when searching for one word onlyClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 105

core/kernel/db/cat_event_handler.php

core/units/categories/categories_event_handler.php

INP-1409 - Don't calculate search relevance twice, when searching for one word only
ClosedPublic
Actions

Revision Contents
Changeset List