Unexpected output: Affected paths: relative - resubmit patch.
⚙ D128 INP-1475 - Teach "st_ContentBlock" tag to recognize "button_title" parameter
Page MenuHomeIn-Portal Phabricator
Differential D128

INP-1475 - Teach "st_ContentBlock" tag to recognize "button_title" parameter
ClosedPublic
Actions

Authored by erik on Sep 15 2015, 5:00 AM.

Details

Reviewers
alex
Commits
rINP16743: Fixes INP-1475 - Teach "st_ContentBlock" tag to recognize "button_title"…
Summary

Added button_title parameter

Test Plan
  1. select simple theme
  2. change index.tpl of this theme - add button_title="la_Yes" attribute to <inp2:st_ContentBlock num="1"/> tag in this file
  3. go to Website & Content → Browse Website, click on Content Mode tab
  4. confirm that on page in Content Mode button Yes is shown
  5. change index.tpl of simple theme - set empty value for existing button_title attribute
  6. confirm that on page in Content Mode Edit Content button has default title

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 1106
Build 1106: arc lint + arc unit

Event Timeline

erik updated this revision to Diff 304.Sep 15 2015, 5:00 AM
erik retitled this revision from to INP-1475 - Make <inp2:st_ContentBlock/> recognize "button_title" parameter.
erik updated this object.
erik edited the test plan for this revision. (Show Details)
erik added a reviewer: alex.
erik added 1 JIRA issue(s): INP-1475.
alex added a project: Restricted Project.Mar 10 2016, 5:10 AM
alex retitled this revision from INP-1475 - Make <inp2:st_ContentBlock/> recognize "button_title" parameter to INP-1475 - Teach "st_ContentBlock" tag to recognize "button_title" parameter.Jul 16 2016, 7:07 AM
alex updated this revision to Diff 1074.Jul 29 2022, 1:26 AM

Rebasing

alex accepted this revision.Jul 29 2022, 1:27 AM
This revision is now accepted and ready to land.Jul 29 2022, 1:27 AM
Closed by commit rINP16743: Fixes INP-1475 - Teach "st_ContentBlock" tag to recognize "button_title"… (authored by alex, committed by ). · Explain WhyNov 9 2022, 9:16 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 130416249Sep 15 2015, 5:00 AM
★
★
Diff 2107416722RebasingJul 29 2022, 1:26 AM
★
★
Diff 3111416740rINP16743Nov 9 2022, 9:16 AM
★
★

Diff 1074

View Options

core/units/content/content_tp.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server