- login to the Admin Console
- go to User Management → Users section
- type mem in the Primary Group column filter and press the Search button
- open Debugger
- confirm, that:
- filter by g.Name column was added into the WHERE clause
- there was not HAVING clause added
- press Reset button
- type mem in the genral search box above the grid on the right side and press the Search button
- open Debugger
- confirm, that:
- filter by g.Name column was added into the WHERE clause
- there was not HAVING clause added
- press Reset button
Details
Details
Diff Detail
Diff Detail
- Repository
- rINP In-Portal
- Branch
- /in-portal/branches/5.2.x
- Lint
Lint Errors Excuse: Issues reported aren't related to the changed code. Severity Location Code Message Error core/kernel/db/dblist.php:822 PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.SpaceBeforeCloseBrace CodingStandard.WhiteSpace.ControlStructureSpacing.SpaceBeforeCloseBrace Error core/kernel/db/dblist.php:822 PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.SpacingAfterOpenBrace CodingStandard.WhiteSpace.ControlStructureSpacing.SpacingAfterOpenBrace Error core/kernel/db/dblist.php:824 PHPCS.E.PSR2.Methods.FunctionCallSignature.SpaceBeforeCloseBracket PSR2.Methods.FunctionCallSignature.SpaceBeforeCloseBracket Error core/kernel/db/dblist.php:824 PHPCS.E.Squiz.Classes.SelfMemberReference.NotUsed Squiz.Classes.SelfMemberReference.NotUsed - Unit
No Unit Test Coverage - Build Status
Buildable 1134 Build 1134: arc lint + arc unit
Event Timeline
Comment Actions
There is not simple filter by g.Name, but complex filter "((1) AND ( (g.Name) LIKE '%mem%'))", where part "(1) AND" is excessive. Maybe, this "(1) AND" should be removed from SQL request.
Comment Actions
I'm aware of that extra (1) AND SQL fragment. This is a result of enabling the Perform Exact Search system setting (enabled by default) from the Configuration → Website → Advanced section. It has an effect on all like filters on all grids.
Since removing that fragment won't give any performance benefits I'm suggesting keeping it for now.
If that was the only concern in this differential revision, then please mark it as Accepted.