Unexpected output: Affected paths: relative - resubmit patch.
⚙ D447 INP-1842 - Cache user primary group detection during Checkout
Page MenuHomeIn-Portal Phabricator
Differential D447

INP-1842 - Cache user primary group detection during Checkout
ClosedPublic
Actions

Authored by alex on Jul 6 2023, 12:27 PM.

Details

Reviewers
erik
Commits
rMINC16775: Bug INP-1842 - Cache user primary group detection during Checkout
rINP16774: Fixes INP-1842 - Cache user primary group detection during Checkout
Test Plan
  1. In the IDE:
    1. open core/admin_templates/users/users_list.tpl file for editing
    2. uncomment the setprimary toolbar button
    3. save changes
  2. Tab 1 - Admin Console:
    1. login to Admin Console
    2. go to Website & Content → Structure & Data → Products section
    3. use the New Product toolbar button to create a Tangible, that will have:
      • $10 pricing for Everyone group
      • $5 pricing for Admin group
      • $2 pricing for Member group
    4. confirm, that in the products grid, this product is shown with $5 pricing in Admin Console
    5. right-click on the shortcut icon next to that product name and choose Open Link in New Tab from the Context Menu
  3. Tab 2 - Front-End:
    1. confirm, that the Front-End product detail page opens in a New Tab (if you're logged in, then logout)
    2. confirm, that the product price, displayed on the product detail page for a non-logged-in user is $10
    3. click on the Buy Now button
    4. confirm, that you're redirected to the shopping cart page
    5. confirm, that the product price (Your Price column), displayed on the shopping cart page for a non-logged-in user is $10
    6. click on the product name to return to its detail page
    7. confirm, that you're redirected to the product detail page
    8. perform Front-End login using the login form in the sidebar (create a user in the Admin Console if you don't have it)
    9. confirm, that the product price, displayed on the product detail page for a logged-in user is $2
    10. click on the Buy Now button
    11. confirm, that you're redirected to the shopping cart page
    12. confirm, that the product price (Your Price column), displayed on the shopping cart page for a logged-in user is $2
  4. Tab 1 - Admin Console:
    1. go to the User Management → Users section
    2. select the user that is currently logged in on the Front-End
    3. click the Primary toolbar button
    4. select the admin group
    5. press the Save toolbar button
  5. Tab 1 - Front-End:
    1. reload the page
    2. confirm, that the product price, displayed on the product detail page for an administrator is $5
    3. click on the Buy Now button
    4. confirm, that you're redirected to the shopping cart page
    5. confirm, that the product price (Your Price column), displayed on the shopping cart page for a logged-in user is $5

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint ErrorsExcuse: Not fixing unrelated issues.
SeverityLocationCodeMessage
Errorcore/units/helpers/user_helper.php:753PHPCS.E.CodingStandard.Classes.ClassDeclaration.SpaceBeforeCloseBraceCodingStandard.Classes.ClassDeclaration.SpaceBeforeCloseBrace
Errormodules/in-commerce/units/orders/order_calculator.php:529PHPCS.E.CodingStandard.Commenting.InlineComment.InvalidEndCharCodingStandard.Commenting.InlineComment.InvalidEndChar
Errormodules/in-commerce/units/orders/order_calculator.php:529PHPCS.E.CodingStandard.Commenting.InlineComment.SpacingAfterCodingStandard.Commenting.InlineComment.SpacingAfter
Errormodules/in-commerce/units/products/products_item.php:41PHPCS.E.CodingStandard.Commenting.InlineComment.InvalidEndCharCodingStandard.Commenting.InlineComment.InvalidEndChar
Errormodules/in-commerce/units/products/products_item.php:41PHPCS.E.CodingStandard.Commenting.InlineComment.NotCapitalCodingStandard.Commenting.InlineComment.NotCapital
Errormodules/in-commerce/units/products/products_item.php:87PHPCS.E.CodingStandard.Classes.ClassDeclaration.SpaceBeforeCloseBraceCodingStandard.Classes.ClassDeclaration.SpaceBeforeCloseBrace
Errormodules/in-commerce/units/products/products_item.php:87PHPCS.E.Generic.WhiteSpace.ScopeIndent.IncorrectExactGeneric.WhiteSpace.ScopeIndent.IncorrectExact
Unit
No Unit Test Coverage
Build Status
Buildable 1192
Build 1192: arc lint + arc unit

Event Timeline

alex created this revision.Jul 6 2023, 12:27 PM
alex requested review of this revision.Jul 6 2023, 12:27 PM
alex edited the test plan for this revision. (Show Details)Jul 6 2023, 12:29 PM
erik accepted this revision.Jul 7 2023, 3:11 AM
This revision is now accepted and ready to land.Jul 7 2023, 3:11 AM
alex added a project: Restricted Project.Jul 13 2023, 9:52 AM
This revision was landed with ongoing or failed builds.Nov 22 2023, 2:51 AM
Closed by commit rINP16774: Fixes INP-1842 - Cache user primary group detection during Checkout (authored by alex, committed by ). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 1115316754Jul 6 2023, 12:27 PM
★
★
Diff 2117416773rINP16774Nov 22 2023, 2:51 AM
★
★

Diff 1153

View Options

core/units/helpers/user_helper.php

Loading...
View Options

core/units/users/users_event_handler.php

Loading...
View Options

modules/in-commerce/units/orders/order_calculator.php

Loading...
View Options

modules/in-commerce/units/pricing/pricing_event_handler.php

Loading...
View Options

modules/in-commerce/units/products/products_event_handler.php

Loading...
View Options

modules/in-commerce/units/products/products_item.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server