Unexpected output: Affected paths: no mapping - resubmit patch.
⚙ D449 MINC-200 - Cache results of the "ShippingQuoteEngine::initProperties" method
Page MenuHomeIn-Portal Phabricator
Differential D449

MINC-200 - Cache results of the "ShippingQuoteEngine::initProperties" method
ClosedPublic
Actions

Authored by alex on Jul 17 2023, 4:07 AM.

Details

Reviewers
erik
Commits
rMINC16777: Fixes MINC-200 - Cache results of the "ShippingQuoteEngine::initProperties"…
Test Plan
  1. login to Admin Console
  2. go to Website & Content → Structure & Data → Products section
  3. create a tangible product in Active status
  4. go to E-commerce → Orders section
  5. switch to the Incomplete tab
  6. create new sales order by populating data on each of the tabs
  7. once on the Shipping tab open Debugger and confirm, that there is a single SQL statement from the ShippingQuoteEngines database table present
  8. procced to the next tab
  9. return to the Shipping tab
  10. open Debugger and confirm, that there is a no SQL statements from the ShippingQuoteEngines database table present

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 1194
Build 1194: arc lint + arc unit

Event Timeline

alex created this revision.Jul 17 2023, 4:07 AM
alex requested review of this revision.Jul 17 2023, 4:07 AM
alex added a project: Restricted Project.Jul 17 2023, 4:08 AM
alex updated this revision to Diff 1156.Jul 17 2023, 4:24 AM

Tagged cachable SQL query.

erik accepted this revision.Jul 20 2023, 6:04 AM
This revision is now accepted and ready to land.Jul 20 2023, 6:04 AM
alex retitled this revision from INP-1844 - Cache results of the "ShippingQuoteEngine::initProperties" method to MINC-200 - Cache results of the "ShippingQuoteEngine::initProperties" method.Nov 22 2023, 2:57 AM
alex updated JIRA issue(s): added 1 MINC-200; removed 1 INP-1844.
Closed by commit rMINC16777: Fixes MINC-200 - Cache results of the "ShippingQuoteEngine::initProperties"… (authored by alex, committed by ). · Explain WhyNov 22 2023, 2:58 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 1115516754Jul 17 2023, 4:07 AM
★
★
Diff 2115616754Tagged cachable SQL query.Jul 17 2023, 4:24 AM
★
★
Diff 3117616775rMINC16777Nov 22 2023, 2:58 AM
★
★

Diff 1155

View Options

modules/in-commerce/units/shipping_quote_engines/shipping_quote_engine.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server