Differential D449

MINC-200 - Cache results of the "ShippingQuoteEngine::initProperties" method
ClosedPublic
Actions

Authored by alex on Jul 17 2023, 4:07 AM.

Details

Reviewers

erik

Commits

rMINC16777: Fixes MINC-200 - Cache results of the "ShippingQuoteEngine::initProperties"…

Test Plan

login to Admin Console
go to Website & Content → Structure & Data → Products section
create a tangible product in Active status
go to E-commerce → Orders section
switch to the Incomplete tab
create new sales order by populating data on each of the tabs
once on the Shipping tab open Debugger and confirm, that there is a single SQL statement from the ShippingQuoteEngines database table present
procced to the next tab
return to the Shipping tab
open Debugger and confirm, that there is a no SQL statements from the ShippingQuoteEngines database table present

Diff Detail

Repository

rINP In-Portal

Branch

/in-portal/branches/5.2.x

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 1195
Build 1195: arc lint + arc unit

Event Timeline

alex created this revision.Jul 17 2023, 4:07 AM

Herald added a reviewer: erik. · View Herald TranscriptJul 17 2023, 4:07 AM

alex requested review of this revision.Jul 17 2023, 4:07 AM

Harbormaster completed remote builds in B1194: Diff 1155.Jul 17 2023, 4:07 AM

alex added a project: Restricted Project.Jul 17 2023, 4:08 AM

Tagged cachable SQL query.

Harbormaster completed remote builds in B1195: Diff 1156.Jul 17 2023, 4:24 AM

erik accepted this revision.Jul 20 2023, 6:04 AM

This revision is now accepted and ready to land.Jul 20 2023, 6:04 AM

alex retitled this revision from INP-1844 - Cache results of the "ShippingQuoteEngine::initProperties" method to MINC-200 - Cache results of the "ShippingQuoteEngine::initProperties" method.Nov 22 2023, 2:57 AM

alex updated JIRA issue(s): added 1 MINC-200; removed 1 INP-1844.

Closed by commit rMINC16777: Fixes MINC-200 - Cache results of the "ShippingQuoteEngine::initProperties"… (authored by alex, committed by ). · Explain WhyNov 22 2023, 2:58 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			modules/in-commerce/units/shipping_quote_engines/shipping_quote_engine.php (43 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1155	16754		Jul 17 2023, 4:07 AM	★	★
Diff 2	1156	16754	Tagged cachable SQL query.	Jul 17 2023, 4:24 AM	★	★
Diff 3	1176	16775	rMINC16777	Nov 22 2023, 2:58 AM	★	★

Commit	Parents	Author	Summary	Date
#fake-hash			Ignore it :) (Show More…)

Diff 1156

View Options

modules/in-commerce/units/shipping_quote_engines/shipping_quote_engine.php

MINC-200 - Cache results of the "ShippingQuoteEngine::initProperties" methodClosedPublicActions