- create 11 products with names, containing Test & fun text
- enter Test & fun text into search box
- after search form is submitted verify, that entered keywords are displayed in
- search input box
- url (in the urlencoded form)
- page title
- click on More... link under search results
- confirm, that previously entered keywords appear in same places (as above)
- click on the 2 to go to 2nd page in search results (pagination control is located under the list)
- confirm, that previously entered keywords appear in same places (as above)
Details
- Reviewers
alex
Diff Detail
- Repository
- rINP In-Portal
- Branch
- /in-portal/branches/5.2.x
- Lint
No Linters Available - Unit
No Unit Test Coverage
Event Timeline
core/kernel/db/db_tag_processor.php | ||
---|---|---|
762 ↗ | (On Diff #13) | Please do the following:
|
themes/advanced/platform/elements/content_boxes.elm.tpl | ||
202 ↗ | (On Diff #13) | There is no point in using " because it's not used in any other HTML tag attribute value. So please use ". |
207–208 ↗ | (On Diff #13) | Don't we have any tag like SearchLink that builds link to template and passes keywords to it? |
Adding comment to create corresponding "Issue Link" from JIRA Issue back to this Differential Revision.
themes/advanced/platform/elements/content_boxes.elm.tpl | ||
---|---|---|
207–208 ↗ | (On Diff #13) | No, we don't have such tag. |
themes/advanced/platform/elements/content_boxes.elm.tpl | ||
---|---|---|
207–208 ↗ | (On Diff #13) | Then we should add one I guess. Also there is no such url_escape parameter. |
Fixes.
Used more proper methods for escape/unescape request values.
Fiх to search logic, to allow keywords in URL without full search results recalculation.
The http://qa.in-portal.org/D8?id=120 diff was created using wrong command arc diff --update D8 instead of arc diff --update D8 --cl and that's why it doesn't contain any relevant changes.
core/kernel/processors/main_processor.php | ||
---|---|---|
310–313 ↗ | (On Diff #121) | Return back. |
core/kernel/processors/tag_processor.php | ||
187 ↗ | (On Diff #121) | Undo changes to this method. |
205 ↗ | (On Diff #121) | Undo changes to this method. |
themes/advanced/platform/elements/content_boxes.elm.tpl | ||
207–208 ↗ | (On Diff #121) | Not done. |
Test plan is incomplete. You're testing single search, but not testing consequential search using same/different keywords where searches will return 0 or something. For example for me 2nd search never returns any results.
Also see more detailed comments below.
core/units/helpers/search_helper.php | ||
---|---|---|
817–821 ↗ | (On Diff #204) |
|
825–831 ↗ | (On Diff #204) | I've performed one search and then I'm getting it's result every time I do a next search. I think that conditions used are not quite accurate:
This will match 2 things:
If later is expected behavior then use === false instead of !
This sounds like correct one (new keywords match to session = reuse previous search).
The do_not_drop_search_table request variable is set by 1st OnSimpleSearch event, that is executed and therefore whole condition evaluates to true in that case and no search is performed. See me debugging this below:
This sounds like correct one (search table exists = don't drop it considering that keywords match to previously ones used). |