Unexpected output: Affected paths: relative - resubmit patch.
⚙ D478 INP-1756 - Create "Security*" classes for security-related jobs
Page MenuHomeIn-Portal Phabricator

INP-1756 - Create "Security*" classes for security-related jobs
ClosedPublic

Authored by alex on Jul 31 2024, 3:12 AM.

Details

Test Plan

How to obtain In-Portal 5.2.2-B2 code

  1. in the Terminal (SSH connection to Web Server)
    1. go to the DocumentRoot folder of the Web Server
    2. run the svn co svn://in-portal.org/in-portal/releases/5.2.2-B2 in-portal.522b2 command to perform an SVN Checkout
    3. switch to the in-portal.522b2 folder
    4. run the php tools/configure_profile.php in-portal.full command to update svn:externals property
    5. run the svn update command to checkout missing modules/themes
    6. run the composer install command to create a vendor folder
    7. run the tools/fix_perms.sh command to fix permissions of the system folder

Part 1

  1. perform a clean install of In-Portal 5.3.x (there must be no /system/config.php file present)
  2. confirm, that after Filesystem Check step the $_CONFIG['Misc']['SecurityHmacKey'] and $_CONFIG['Misc']['SecurityEncryptionKey'] keys in the /config.php file are present and populated

Part 2

  1. perform an upgrade from In-Portal 5.2.2-B2 to In-Portal 5.3.x (where security key functionality is absent)
  2. confirm, that after Filesystem Check step the $_CONFIG['Misc']['SecurityHmacKey'] and $_CONFIG['Misc']['SecurityEncryptionKey'] keys in the /config.php file are present and populated

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.3.x
Lint
Lint ErrorsExcuse: Not related to changed code.
SeverityLocationCodeMessage
Errorcore/install.php:609PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.SpaceBeforeCloseBraceCodingStandard.WhiteSpace.ControlStructureSpacing.SpaceBeforeCloseBrace
Errorcore/install.php:609PHPCS.E.CodingStandard.WhiteSpace.ControlStructureSpacing.SpacingAfterOpenBraceCodingStandard.WhiteSpace.ControlStructureSpacing.SpacingAfterOpenBrace
Errorcore/install.php:1113PHPCS.E.CodingStandard.Commenting.FunctionComment.MissingCodingStandard.Commenting.FunctionComment.Missing
Errorcore/install.php:1113PHPCS.E.Squiz.Scope.MethodScope.MissingSquiz.Scope.MethodScope.Missing
Unit
No Unit Test Coverage
Build Status
Buildable 1271
Build 1271: arc lint + arc unit

Event Timeline

alex created this revision.Jul 31 2024, 3:12 AM
alex requested review of this revision.Jul 31 2024, 3:12 AM
erik accepted this revision.Jul 31 2024, 6:40 AM
This comment was removed by alex.
This revision is now accepted and ready to land.Jul 31 2024, 6:40 AM
alex edited the test plan for this revision. (Show Details)Jul 31 2024, 9:47 AM
This revision was landed with ongoing or failed builds.Jul 31 2024, 9:49 AM
This revision was automatically updated to reflect the committed changes.