Differential D491

INP-1880 - Fix notice on missing event permission mapping
Needs ReviewPublic
Actions

Authored by alex on Wed, Oct 23, 8:28 AM.

Tags

Subscribers

None

Details

Reviewers

Test Plan

in IDE:
1. open the core/units/email_templates/email_template_eh.php file for editing
2. in the \EmailTemplateEventHandler::mapPermissions method:
  - set $permissions['OnMassApprove'] key to the Array ('self' => true)
  - set $permissions['OnMassDecline'] key to the Array ('subitem' => 'debug')
  - comment out $permissions['OnSend'] key
3. save changes
in Admin Console:
1. login
2. go to Website & Content → E-mail Templates section
3. select any event
4. press the Enable toolbar button
5. confirm, that page reloaded and no error happened
6. press the Add toolbar button
7. confirm, that new email template form is displayed and no error happened
8. close the new email template form
9. press the Disable toolbar button
10. confirm, that you've got Permission mappings not defined for event email-template <- email-template:OnMassDecline exception and no notices
11. press the Send toolbar button
12. confirm, that you've got Permission mappings not defined for event email-template <- email-template:OnSend exception and no notices

Diff Detail

Repository

Branch

/in-portal/branches/5.2.x

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 1313
Build 1313: arc lint + arc unit

Event Timeline

alex created this revision.Wed, Oct 23, 8:28 AM

Herald added a reviewer: erik. · View Herald TranscriptWed, Oct 23, 8:28 AM

alex requested review of this revision.Wed, Oct 23, 8:28 AM

Harbormaster completed remote builds in B1313: Diff 1265.Wed, Oct 23, 8:28 AM

Harbormaster completed remote builds in B1313: Diff 1265.

alex added a project: Restricted Project.Wed, Oct 23, 8:29 AM

Revision Contents
Changeset List

Diff 1265

core/units/helpers/permissions_helper.php

Loading...