Details
Details
IMPORTANT: This is a Differential Revision for In-Portal 5.3.x.
NOTE: The document root is the directory on a web server where the website files for a domain name are stored.
Part 1 - defaults & file:// protocol
- in IDE:
- open the /system/debug.php file for editing
- comment-out these keys in the $dbg_options array: DBG_LOCAL_BASE_PATH, DBG_EDITOR_URL
- save changes
- in Admin Console
- stay on the login screen
- open the Debugger Report
- use Inspect context menu entry on the 1st file editing link below an SQL query (has application.php:305 text for me)
- confirm, that shown URL:
- is encoded (all the / symbols in the w:/path/to/file part of URL are replaced with %2F)
- URL-decoded version of it looks like file://w:/path/to/file:line_number (/path/to/file - path to a file starting from the Document Root of a Web Server; line_number - line number in that file)
Part 2 - phpstorm:// protocol
- in IDE:
- open the /system/debug.php file for editing
- comment-out these keys in the $dbg_options array: DBG_LOCAL_BASE_PATH
- in the DBG_EDITOR_URL key of the $dbg_options array specify 'phpstorm://open?file=%F&line=%L'
- save changes
- in Admin Console
- stay on the login screen
- open the Debugger Report
- use Inspect context menu entry on the 1st file editing link below an SQL query (has application.php:305 text for me)
- confirm, that shown URL:
- is encoded (all the / symbols in the w:/path/to/file part of URL are replaced with %2F)
- URL-decoded version of it looks like phpstorm://open?file=w:/path/to/file&line=line_number (/path/to/file - path to a file starting from the Document Root of a Web Server; line_number - line number in that file)
Part 3 - vscode:// protocol
- in IDE:
- open the /system/debug.php file for editing
- comment-out these keys in the $dbg_options array: DBG_LOCAL_BASE_PATH
- in the DBG_EDITOR_URL key of the $dbg_options array specify 'vscode://file/%F:%L'
- save changes
- in Admin Console
- stay on the login screen
- open the Debugger Report
- use Inspect context menu entry on the 1st file editing link below an SQL query (has application.php:305 text for me)
- confirm, that shown URL:
- is encoded (all the / symbols in the w:/path/to/file part of URL are replaced with %2F)
- URL-decoded version of it looks like vscode://file/w:/path/to/file:line_number (/path/to/file - path to a file starting from the Document Root of a Web Server; line_number - line number in that file)
Diff Detail
Diff Detail
- Repository
- rINP In-Portal
- Branch
- /in-portal/branches/5.3.x
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 1314 Build 1314: arc lint + arc unit
Event Timeline
Comment Actions
Part 1 - microsoft do not support such links as 'file://' (security issue), so browser does not decode it properly. Result is like "file:///" in the FireFox browser. {F669820}And like 'about:blank#blocked' when trying follow this link in the Chrome browser.
All parts - slashes in the "protocol" parts are not URL-decoded.
Comment Actions
I'm aware of the issue, that prevents file:// links from working. For that reason in D493 the file:// links are replaced with phpstorm:// links.
All parts - slashes in the "protocol" parts are not URL-decoded.
This is a problem with a test plan. I'll correct it.