Page MenuHomeIn-Portal Phabricator

INP-1927 Support "tinyint" data type in Table Structure Generator
Needs ReviewPublic

Authored by erik on Thu, Sep 25, 12:32 PM.

Details

Reviewers
alex
Summary

fixed tinyint column processing for case when length is empty

Test Plan

Test with MySQL 8.x

Preparations

Run following SQL to create test table (replace "inp_" prefix with current system table prefix).

CREATE TABLE `inp_TestTinyInt` (
  `ColumnNone` tinyint DEFAULT NULL,
  `Column3` tinyint(3) DEFAULT NULL
);

Testing

  1. use the “Show Structure” button in the ToolsSystem Tools section on TestTinyInt table
  2. confirm that both columns have “kOptionsFormatter” assigned to them in the unit config field declaration

Diff Detail

Repository
rINP In-Portal
Branch
branches/5.2.x
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 11157
Build 3857: arc lint + arc unit

Event Timeline

erik created this revision.Thu, Sep 25, 12:32 PM
erik requested review of this revision.Thu, Sep 25, 12:32 PM
erik edited the test plan for this revision. (Show Details)Thu, Sep 25, 12:36 PM