removed excessive TitleField key from discount items and affiliate plan items configuration
Details
Details
- Reviewers
alex
Preparations - make api tab working
- In the affiliate_plans_config.php uncomment 'api' in the 'SubItems' array.
- In the affiliate_plans_config.php uncomment 'items' in the 'EditTabPresets' array.
- Fix affilite_plans_items.tpl - add pagination_prefix="api" parameter to the RenderElement name="combined_header" tag.
Testing di unit changes
- login to the adm. console
- go to the E-commerce → Discounts & Certificates section
- use adm.console interface in the current section to create new discount record, with some sub-records on the Items tab
- confirm that records are created on the Items tab
- go to the Logs & Reports → System Log section
- confirm that no record with warning 'Field "Name" is not defined in "di" unit config' appeared in the System Log
- confirm that no record with notice 'Undefined index: Name' appeared in the System Log
Testing api unit changes
- login to the adm. console
- go to the E-commerce → Affiliates section go to 'Affiliate Plans' tab
- use adm.console interface in the current section to create new affiliate plan record, with some sub-records on the Items tab
- confirm that records are created on the Items tab
- go to the Logs & Reports → System Log section
- confirm that no record with warning 'Field "Name" is not defined in "api" unit config' appeared in the System Log
- confirm that no record with notice 'Undefined index: Name' appeared in the System Log
Diff Detail
Diff Detail
- Repository
- rINP In-Portal
- Branch
- branches/5.2.x
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 11189 Build 3889: arc lint + arc unit
Event Timeline
Comment Actions
- I've noticed, that the same issue happens also with coupi and api units of the In-Commerce. Please expand the Differential Revision code/test plan to cover them as well.
- I've noticed, that you're testing, that notice is gone, but not testing that item adding code still works. Please test that as well.
- I've also renamed the task. Please rename your changelist in the PhpStorm to avoid accidental Differential Revision rename on patch update.