Page MenuHomeIn-Portal Phabricator

INP-1897 Query for HTTP headers in the "kLogger::addRequestData" method only when the HTTPQuery object is available
Needs ReviewPublic

Authored by erik on Feb 5 2025, 4:58 AM.

Details

Reviewers
alex
Summary

prevented unexisting object usage attempt

Test Plan

Test code 1

$this->_logger->addRequestData();

Test code 2

print_r($request_data['Headers']);

Test

  1. add test code 1 to the kApplication::Init method, before HttpQuery property initialization
  2. login to the adn.console
  3. go to the User ManagementUsers section
  4. confirm, that users grid is shown without any errors/notices
  5. remove test code 1
  6. add test code 2 to the kLogger::adRequestData method after $request_data variable is set
  7. refresh adm.console page
  8. confirm, that non-empty array data is displaying on page top, before normal output

Diff Detail

Repository
rINP In-Portal
Branch
branches/5.3.x
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 11191
Build 3891: arc lint + arc unit

Event Timeline

erik created this revision.Feb 5 2025, 4:58 AM
erik requested review of this revision.Feb 5 2025, 4:58 AM
erik edited the test plan for this revision. (Show Details)Feb 5 2025, 4:59 AM
erik edited the test plan for this revision. (Show Details)
erik edited the test plan for this revision. (Show Details)Feb 5 2025, 5:02 AM
alex requested changes to this revision.EditedApr 30 2025, 4:30 AM

Please:

  1. resubmit from the 5.3.x branch, because an associated Jira task is for the 5.3.x branch as well.
  2. (test plan only tests 50% of changed code) improve test plan by checking, that request header logging still works, when HttpQuery is present
This revision now requires changes to proceed.Apr 30 2025, 4:30 AM
alex updated this revision to Diff 1440.Tue, Feb 3, 3:45 AM

Resubmitting the same code from the 5.3.x branch.

alex requested changes to this revision.Tue, Feb 3, 3:47 AM
  1. resubmit from the 5.3.x branch, because an associated Jira task is for the 5.3.x branch as well.

Done by me.

  1. (test plan only tests 50% of changed code) improve test plan by checking, that request header logging still works, when HttpQuery is present

Still needs to be done.

This revision now requires changes to proceed.Tue, Feb 3, 3:48 AM
erik requested review of this revision.Tue, Feb 3, 6:00 AM
erik edited the test plan for this revision. (Show Details)
erik edited the test plan for this revision. (Show Details)