Page MenuHomeIn-Portal Phabricator
  • Changed Files
  • core/admin_templates/js/grid.js

INP-1955 - Implement keyboard-based grid page navigation
ClosedPublic

Authored by alex on Mar 30 2026, 6:49 AM.

Details

Test Plan
NOTE: Test in Google Chrome and Mozilla Firefox.

Part 1 - no prev page from the 1st page

  1. login to the Admin Console
  2. go to the Website & ContentLabels & Phrases section
  3. scenario 1:
    1. go to the 1st page in the list
    2. press the the Left Arrow key
    3. confirm that nothing happened
  4. scenario 2
    1. go to the 1st page in the list
    2. press the the Page Up key
    3. confirm that nothing happened

Part 2 - previous page from the page in the middle

  1. login to the Admin Console
  2. go to the Website & ContentLabels & Phrases section
  3. scenario 1:
    1. go to the 3rd page in the list (non-first & non-last)
    2. press the the Left Arrow key
    3. confirm that you've navigated to the previous page before the current one
  4. scenario 2:
    1. go to the 3rd page in the list (non-first & non-last)
    2. press the the Page Up key
    3. confirm that you've navigated to the previous page before the current one

Part 3 - next page from the page in the middle

  1. login to the Admin Console
  2. go to the Website & ContentLabels & Phrases section
  3. scenario 1:
    1. go to the 3rd page in the list (non-first & non-last)
    2. press the the Right Arrow key
    3. confirm that you've navigated to the next page after the current one
  4. scenario 2:
    1. go to the 3rd page in the list (non-first & non-last)
    2. press the the Page Down key
    3. confirm that you've navigated to the next page after the current one

Part 4 - no next page from the last page

  1. login to the Admin Console
  2. go to the Website & ContentLabels & Phrases section
  3. scenario 1:
    1. go to the last page in the list
    2. press the the Right Arrow key
    3. confirm that nothing happened
  4. scenario 2:
    1. go to the last page in the list
    2. press the the Page Down key while on the non-last page
    3. confirm that nothing happened

Diff Detail

Repository
rINP In-Portal
Branch
branches/5.2.x
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11209
Build 3909: arc lint + arc unit

Event Timeline

alex created this revision.Mar 30 2026, 6:49 AM
alex requested review of this revision.Mar 30 2026, 6:49 AM
erik requested changes to this revision.Mar 30 2026, 9:16 AM

Page Up does that is written for Page Down in the test plan.
Page Down does that is written for Page Up in the test plan.

This revision now requires changes to proceed.Mar 30 2026, 9:16 AM
alex requested review of this revision.Mar 30 2026, 11:02 AM
alex edited the test plan for this revision. (Show Details)

There was an error in the test plan. Corrected now.

Please retest.

erik accepted this revision.Mar 30 2026, 11:44 AM
This revision is now accepted and ready to land.Mar 30 2026, 11:44 AM
This revision was automatically updated to reflect the committed changes.