Differential D71

INP-1432 Process only frames from same domain
ClosedPublic
Actions

Authored by erik on May 5 2015, 4:27 AM.

Details

Reviewers

alex

Commits

rINP16249: Fixes INP-1432 - Process only frames from same domain

Test Plan

open Admin Console
go to Configuration → Website → Advanced section
set Editing Window Style to Modal Window
go to Website & Content → Browse Website section
select Content Mode (in top frame)
input iframe tag like <iframe allowfullscreen="" frameborder="0" height="315" src="https://www.youtube.com/embed/seI3EA7zafw" width="560"></iframe> into some CMS block and press Save button
confirm that modal window closes

Diff Detail

Repository

rINP In-Portal

Branch

/in-portal/branches/5.2.x

Lint

No Linters Available

Unit

No Unit Test Coverage

Event Timeline

erik updated this revision to Diff 171.May 5 2015, 4:27 AM

erik retitled this revision from to INP-1432 Process only frames from same domain.

erik updated this object.

erik edited the test plan for this revision. (Show Details)

erik added 1 JIRA issue(s): INP-1432.

Herald added a reviewer: alex. · View Herald TranscriptMay 5 2015, 4:27 AM

erik edited the test plan for this revision. (Show Details)May 5 2015, 4:31 AM

erik edited edge metadata.

Please implement same protection on other getFrame function in script.js file, as mentioned in task description.

This revision now requires changes to proceed.May 5 2015, 4:32 AM

Made same change in the script.js

alex accepted this revision.May 5 2015, 4:49 AM

alex edited edge metadata.

This revision is now accepted and ready to land.May 5 2015, 4:49 AM

Closed by commit rINP16249: Fixes INP-1432 - Process only frames from same domain (authored by alex). · Explain WhySep 2 2015, 3:59 PM

This revision was automatically updated to reflect the committed changes.

alex edited edge metadata.Mar 10 2016, 6:12 AM

alex added a project: Restricted Project.

Revision Contents
Changeset List

			Path	Packages
M			core/admin_templates/incs/close_popup.tpl (14 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	171	16155		May 5 2015, 4:27 AM	★	★
Diff 2	172	16155	Made same change in the script.js	May 5 2015, 4:48 AM	★	★
Diff 3	295	16247	Commit rINP16249	Sep 2 2015, 3:59 PM	★	★

Commit	Parents	Author	Summary	Date
#fake-hash			Ignore it :) (Show More…)

Diff 171

View Options

core/admin_templates/incs/close_popup.tpl

INP-1432 Process only frames from same domainClosedPublicActions