Page MenuHomeIn-Portal Phabricator
Differential D71

INP-1432 Process only frames from same domain
ClosedPublic
Actions

Authored by erik on May 5 2015, 4:27 AM.

Details

Reviewers
alex
Commits
rINP16249: Fixes INP-1432 - Process only frames from same domain
Test Plan
  1. open Admin Console
  2. go to Configuration → Website → Advanced section
  3. set Editing Window Style to Modal Window
  4. go to Website & Content → Browse Website section
  5. select Content Mode (in top frame)
  6. input iframe tag like <iframe allowfullscreen="" frameborder="0" height="315" src="https://www.youtube.com/embed/seI3EA7zafw" width="560"></iframe> into some CMS block and press Save button
  7. confirm that modal window closes

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

erik updated this revision to Diff 171.May 5 2015, 4:27 AM
erik retitled this revision from to INP-1432 Process only frames from same domain.
erik updated this object.
erik edited the test plan for this revision. (Show Details)
erik added 1 JIRA issue(s): INP-1432.
erik edited the test plan for this revision. (Show Details)May 5 2015, 4:31 AM
erik edited edge metadata.
alex requested changes to this revision.May 5 2015, 4:32 AM
alex edited edge metadata.

Please implement same protection on other getFrame function in script.js file, as mentioned in task description.

This revision now requires changes to proceed.May 5 2015, 4:32 AM
erik updated this revision to Diff 172.May 5 2015, 4:48 AM
erik edited edge metadata.

Made same change in the script.js

alex accepted this revision.May 5 2015, 4:49 AM
alex edited edge metadata.
This revision is now accepted and ready to land.May 5 2015, 4:49 AM
Closed by commit rINP16249: Fixes INP-1432 - Process only frames from same domain (authored by alex). · Explain WhySep 2 2015, 3:59 PM
This revision was automatically updated to reflect the committed changes.
alex edited edge metadata.Mar 10 2016, 6:12 AM
alex added a project: Restricted Project.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 117116155May 5 2015, 4:27 AM
★
★
Diff 217216155Made same change in the script.jsMay 5 2015, 4:48 AM
★
★
Diff 329516247Commit rINP16249Sep 2 2015, 3:59 PM
★
★

Diff 172

View Options

core/admin_templates/incs/close_popup.tpl

Loading...
View Options

core/admin_templates/js/script.js

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server