Unexpected output: Affected paths: no mapping - resubmit patch.
⚙ D81 MINC-127 Optimize "ord_UsingCreditCard" tag
Page MenuHomeIn-Portal Phabricator
Differential D81

MINC-127 Optimize "ord_UsingCreditCard" tag
ClosedPublic
Actions

Authored by glebs on Jun 10 2015, 10:08 AM.

Details

Reviewers
alex
Commits
rMINC16248: Fixes MINC-127 - Optimize "ord:UsingCreditCard" tag
Test Plan
  1. Create several orders with different payment types: with CC and without
  2. Update element grid_billinglink_td and add some usage of tag UsingCreditCard
  3. Check any orders list for SQL queries - it should have only one select from payment types table

Diff Detail

Repository
rINP In-Portal
Branch
/w/in-portal.full/branches/5.2.x
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

glebs updated this revision to Diff 213.Jun 10 2015, 10:08 AM
glebs retitled this revision from to MINC-127 Optimize "ord:UsingCreditCard" tag.
glebs updated this object.
glebs edited the test plan for this revision. (Show Details)
glebs added 1 JIRA issue(s): MINC-127.
alex requested changes to this revision.Jun 10 2015, 10:17 AM
alex edited edge metadata.
alex added inline comments.
modules/in-commerce/units/orders/orders_tag_processor.php
523

It should be boolean, not bool.

534

The INNER JOIN is equivalent to just JOIN.

538–539

This should be done only when needed, not all the time.

544

Please rename to $payment_type.

This revision now requires changes to proceed.Jun 10 2015, 10:17 AM
glebs updated this revision to Diff 214.Jun 10 2015, 10:21 AM
glebs edited edge metadata.

Requested changes

alex requested changes to this revision.Jun 10 2015, 10:37 AM
alex edited edge metadata.
alex added inline comments.
modules/in-commerce/units/orders/orders_tag_processor.php
555–558

We can actually extract this to separate getPrimaryPaymentType that will have $primary_payment_type variable in it.

This revision now requires changes to proceed.Jun 10 2015, 10:37 AM
glebs updated this revision to Diff 215.Jun 10 2015, 10:55 AM
glebs edited edge metadata.

new getPrimaryPaymentType method

alex accepted this revision.Jun 10 2015, 11:39 AM
alex edited edge metadata.
This revision is now accepted and ready to land.Jun 10 2015, 11:39 AM
Closed by commit rMINC16248: Fixes MINC-127 - Optimize "ord:UsingCreditCard" tag (authored by alex). · Explain WhySep 2 2015, 3:55 PM
This revision was automatically updated to reflect the committed changes.
alex edited edge metadata.Mar 10 2016, 6:11 AM
alex added a project: Restricted Project.
alex retitled this revision from MINC-127 Optimize "ord:UsingCreditCard" tag to MINC-127 Optimize "ord_UsingCreditCard" tag.Jul 16 2016, 6:33 AM

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 121316206Jun 10 2015, 10:08 AM
★
★
Diff 221416206Requested changesJun 10 2015, 10:21 AM
★
★
Diff 321516206new getPrimaryPaymentType methodJun 10 2015, 10:55 AM
★
★
Diff 429416244Commit rMINC16248Sep 2 2015, 3:55 PM
★
★

Diff 213

View Options

modules/in-commerce/units/orders/orders_tag_processor.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server