Unexpected output: Affected paths: relative - resubmit patch.
⚙ D89 INP-1441 - Fix JavaScript error during link editing in the CKEditor
Page MenuHomeIn-Portal Phabricator
  • Changed Files
  • core/ckeditor/plugins/my_link/plugin.js
Differential D89

INP-1441 - Fix JavaScript error during link editing in the CKEditor
ClosedPublic
Actions

Authored by alex on Jul 24 2015, 11:29 AM.

Details

Reviewers
glebs
Commits
rINP16262: Fixes INP-1441 - JavaScript error, when editing link in CKEditor
Test Plan
  1. open website in Content Mode
  2. edit content any block and type this in it (view Source toolbar button in CKEditor): aa <a class="cc" href="#" title="tt">link</a> bb
  3. save content block
  4. edit that content block again and this time:
    • click on the link
    • right click on the link
    • select Edit Link menu item
  5. confirm, that no JS error has happened at this point

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

alex updated this revision to Diff 223.Jul 24 2015, 11:29 AM
alex retitled this revision from to INP-1441 - JavaScript error, when editing link in CKEditor.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1441.
glebs accepted this revision.Sep 7 2015, 1:37 AM
glebs edited edge metadata.
This revision is now accepted and ready to land.Sep 7 2015, 1:37 AM
Closed by commit rINP16262: Fixes INP-1441 - JavaScript error, when editing link in CKEditor (authored by alex). · Explain WhySep 27 2015, 3:16 AM
This revision was automatically updated to reflect the committed changes.
alex edited edge metadata.Mar 10 2016, 5:52 AM
alex added a project: Restricted Project.
alex retitled this revision from INP-1441 - JavaScript error, when editing link in CKEditor to INP-1441 - Fix JavaScript error during link editing in the CKEditor.Jul 16 2016, 7:16 AM

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 122316200Jul 24 2015, 11:29 AM
★
★
Diff 232616261Commit rINP16262Sep 27 2015, 3:16 AM
★
★

Diff 223

View Options

core/ckeditor/plugins/my_link/plugin.js

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server