Differential D94

INP-1445 - Change CKEditor style loading to allow working on Front-End
ClosedPublic
Actions

Authored by alex on Jul 27 2015, 8:08 AM.

Details

Reviewers

glebs

Commits

rINP16228: Fixes INP-1445 - Inline CKEditor styles aren't working

Test Plan

go to platform/inc/styles.css file and change H3 tag background color to green
in the Content Mode click the orange Edit Content button
confirm, that Alex Blue Title and Red Title in Styles dropdown in CKEditor toolbar now has green background
in the Front-End template add the mode="inline" to any content block
confirm, that:
- the Edit Content button is gone, but orange dashed border stayed
- clicking inside dashed border would reveal CKEditor toolbar
- in shown toolbar the Styles dropdown looks like one of CKEditor from the modal window (green background on selected styles)

Diff Detail

Repository

rINP In-Portal

Branch

/in-portal/branches/5.3.x

Lint

Lint OK

Unit

No Unit Test Coverage

Event Timeline

alex updated this revision to Diff 228.Jul 27 2015, 8:08 AM

alex retitled this revision from to INP-1445 - Inline CKEditor styles aren't working.

alex updated this object.

alex edited the test plan for this revision. (Show Details)

alex added 1 JIRA issue(s): INP-1445.

Herald added a reviewer: glebs. · View Herald TranscriptJul 27 2015, 8:08 AM

glebs accepted this revision.Aug 27 2015, 3:06 AM

glebs edited edge metadata.

This revision is now accepted and ready to land.Aug 27 2015, 3:06 AM

Closed by commit rINP16228: Fixes INP-1445 - Inline CKEditor styles aren't working (authored by alex). · Explain WhySep 1 2015, 3:30 AM

This revision was automatically updated to reflect the committed changes.

alex edited edge metadata.Mar 10 2016, 6:10 AM

alex added a project: Restricted Project.

alex retitled this revision from INP-1445 - Inline CKEditor styles aren't working to INP-1445 - Change CKEditor style loading to allow working on Front-End.Jul 15 2016, 2:33 PM

Revision Contents
Changeset List

			Path	Packages
M			core/units/helpers/fck_helper.php (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	228	16200		Jul 27 2015, 8:08 AM	★	★
Diff 2	274	16226	Commit rINP16228	Sep 1 2015, 3:30 AM	★	★

Commit	Parents	Author	Summary	Date
#fake-hash			Ignore it :) (Show More…)

Diff 228

View Options

core/units/helpers/fck_helper.php

INP-1445 - Change CKEditor style loading to allow working on Front-EndClosedPublicActions