Differential D102

INP-1455 - Prevent direct access to pages configured with external url
ClosedPublic
Actions

Authored by alex on Jul 30 2015, 10:11 AM.

Details

Reviewers

glebs

Commits

rINP16267: Fixes INP-1455 - Prevent direct access to page configured with external urls

Test Plan

on Front-End
- pick any page, that is shown in menu
- write down it's current url
in Admin Console:
- edit page and specify any external url in Link to External URL field
on Front-End
- refresh the page with menu
- confirm that page url in menu now points to the external url
- manually type url, that you've remembered before
- confirm, that 302 redirect has happened to proper external url (before page content was shown)

Diff Detail

Repository

rINP In-Portal

Branch

/in-portal/branches/5.2.x

Lint

Lint Errors

Excuse: Will be fixing in 5.3.x.

Unit

No Unit Test Coverage

Event Timeline

alex updated this revision to Diff 242.Jul 30 2015, 10:11 AM

alex retitled this revision from to INP-1455 - Prevent direct access to page configured with external urls.

alex updated this object.

alex edited the test plan for this revision. (Show Details)

alex added 1 JIRA issue(s): INP-1455.

Herald added a reviewer: glebs. · View Herald TranscriptJul 30 2015, 10:11 AM

glebs accepted this revision.Sep 8 2015, 2:05 AM

glebs edited edge metadata.

This revision is now accepted and ready to land.Sep 8 2015, 2:05 AM

Closed by commit rINP16267: Fixes INP-1455 - Prevent direct access to page configured with external urls (authored by alex). · Explain WhySep 27 2015, 4:38 AM

This revision was automatically updated to reflect the committed changes.

alex edited edge metadata.Mar 10 2016, 6:08 AM

alex added a project: Restricted Project.

alex retitled this revision from INP-1455 - Prevent direct access to page configured with external urls to INP-1455 - Prevent direct access to pages configured with external url.Jul 16 2016, 7:12 AM

Revision Contents
Changeset List

			Path	Packages
M			core/kernel/utility/http_query.php (7 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	242	16200		Jul 30 2015, 10:11 AM	★	★
Diff 2	332	16266	Commit rINP16267	Sep 27 2015, 4:38 AM	★	★

Commit	Parents	Author	Summary	Date
#fake-hash			Ignore it :) (Show More…)

Diff 242

View Options

core/kernel/utility/http_query.php

INP-1455 - Prevent direct access to pages configured with external urlClosedPublicActions