Page MenuHomeIn-Portal Phabricator

INP-1453 Allow using "AdminEditButton" tag several times for same item
ClosedPublic

Authored by glebs on Jul 31 2015, 2:04 AM.

Details

Test Plan

Test using inportal with advanced theme

  1. Create new link in Website & ContentStructure & DataDirectory section
  2. In themes/advanced/in-link/elements/links.elm.tpl add <inp2:AdminEditButton test="testvalue"/> just after <inp2:AdminEditButton/>
  3. Goto Website & ContentBrowse Website, navigate to Directory section and switch to Content Mode
  4. Open Network tab in browser developer tools
  5. Click on first Edit Item button near created link and check url with OnEdit event doesn't contains test=testvalue
  6. Click on second Edit Item button near created link and check url with OnEdit event contains test=testvalue

Diff Detail

Repository
rINP In-Portal
Branch
/w/in-portal.full/branches/5.2.x
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

glebs updated this revision to Diff 243.Jul 31 2015, 2:04 AM
glebs retitled this revision from to INP-1453 Multiple AdminEditButton for same item doesn't work properly.
glebs updated this object.
glebs edited the test plan for this revision. (Show Details)
glebs added 1 JIRA issue(s): INP-1453.
glebs edited the test plan for this revision. (Show Details)Jul 31 2015, 2:05 AM
glebs edited edge metadata.
alex accepted this revision.Sep 18 2015, 7:03 AM
alex edited edge metadata.
This revision is now accepted and ready to land.Sep 18 2015, 7:03 AM
This revision was automatically updated to reflect the committed changes.
alex edited edge metadata.Mar 10 2016, 5:48 AM
alex added a project: Restricted Project.
alex retitled this revision from INP-1453 Multiple AdminEditButton for same item doesn't work properly to INP-1453 Allow using "AdminEditButton" tag several times for same item.Jul 16 2016, 7:13 AM