Differential D113

INP-1463 - Use "http_build_query" for file editing link building
ClosedPublic
Actions

Authored by alex on Aug 15 2015, 2:26 PM.

Details

Reviewers

glebs

Commits

rINP16221: Fixes INP-1463 - Use "http_build_query" for file editing link building

Test Plan

before applying the patch open debugger and copy link to any file (e.g application.php looks like phpstorm://open?file=/Volumes/web/d/in-portal.53x/core/kernel/application.php&line=305 for me)
apply the patch
copy link to same file again (e.g. application.php looks like phpstorm://open?file=%2FVolumes%2Fweb%2Fd%2Fin-portal.53x%2Fcore%2Fkernel%2Fapplication.php&line=305 for me)
confirm that argument values in url are url-encoded

Diff Detail

Repository

rINP In-Portal

Branch

/in-portal/branches/5.3.x

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 83
Build 83: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 253.Aug 15 2015, 2:26 PM

alex retitled this revision from to INP-1463 - Use "http_build_query" for file editing link building.

alex updated this object.

alex edited the test plan for this revision. (Show Details)

alex added 1 JIRA issue(s): INP-1463.

Herald added a reviewer: glebs. · View Herald TranscriptAug 15 2015, 2:26 PM

glebs accepted this revision.Aug 31 2015, 2:11 AM

glebs edited edge metadata.

This revision is now accepted and ready to land.Aug 31 2015, 2:11 AM

Closed by commit rINP16221: Fixes INP-1463 - Use "http_build_query" for file editing link building (authored by alex). · Explain WhySep 1 2015, 2:37 AM

This revision was automatically updated to reflect the committed changes.

alex added a child revision: D136: INP-1483 - Use "path" in from DBG_EDITOR_URL constant only when available.Sep 20 2015, 8:50 AM

alex added a child revision: D492: INP-1882 - Rework URL-encoding in Debugger Report file URLs.Sat, Oct 26, 9:03 AM

Revision Contents
Changeset List

			Path	Packages
M			core/kernel/utility/debugger.php (41 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	253	16207		Aug 15 2015, 2:26 PM	★	★
Diff 2	267	16220	Commit rINP16221	Sep 1 2015, 2:37 AM	★	★

Commit	Parents	Author	Summary	Date
#fake-hash			Ignore it :) (Show More…)

Status	Author	Revision
Closed	alex	D492 INP-1882 - Rework URL-encoding in Debugger Report file URLs
Closed	alex	D136 INP-1483 - Use "path" in from DBG_EDITOR_URL constant only when available
Closed	alex	D113 INP-1463 - Use "http_build_query" for file editing link building

Diff 253

View Options

core/kernel/utility/debugger.php

INP-1463 - Use "http_build_query" for file editing link buildingClosedPublicActions