Page MenuHomeIn-Portal Phabricator

INP-1439 - Fire "m:OnAfterConfigRead" event during Url Processing
ClosedPublic

Authored by alex on Jul 9 2015, 11:42 AM.

Details

Test Plan
NOTE: Mod-rewrite must be disabled before doing this test.

Part 1

  1. create an after hook to m:OnAfterConfigRead event
  2. in above created hook append new key/value pair to QueryString array (beware not to break index sequence)
  3. while on homepage click on any other page link (within same website)
  4. confirm, that - count in env request variable has increased by 1
  5. alter url in browser by hand and append any value after last - in the env request variable
  6. confirm, that links on page after it has been reloaded now contain manually appended value

Part 2

  1. put breakpoint in hook to the m:OnAfterConfigRead event created before
  2. clear cache (e.g. restart memcache OR truncate SystemCache table)
  3. reload page url
  4. confirm, that hook was called (that was from cold start)
  5. reload page url
  6. confirm, that hook was called (that was from warm start)

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 114
Build 114: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 219.Jul 9 2015, 11:42 AM
alex retitled this revision from to INP-1439 - The "m:OnAfterConfigRead" event isn't fired during url processing.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1439.
glebs accepted this revision.Sep 2 2015, 1:57 AM
glebs edited edge metadata.
This revision is now accepted and ready to land.Sep 2 2015, 1:57 AM
alex planned changes to this revision.Sep 2 2015, 5:10 AM

The m:OnAfterConfigRead isn't called during Application cold start.

alex updated this revision to Diff 277.Sep 2 2015, 5:28 AM
alex edited edge metadata.

Execute m:OnAfterConfigRead event during warm start before url processing is started.

This revision is now accepted and ready to land.Sep 2 2015, 5:28 AM
alex requested a review of this revision.Sep 2 2015, 5:31 AM
alex edited the test plan for this revision. (Show Details)
alex edited edge metadata.

Please re-test. I've added code to handle cold start.

glebs accepted this revision.Sep 3 2015, 2:05 AM
glebs edited edge metadata.
This revision is now accepted and ready to land.Sep 3 2015, 2:05 AM
This revision was automatically updated to reflect the committed changes.
alex edited edge metadata.Mar 10 2016, 5:54 AM
alex added a project: Restricted Project.
alex retitled this revision from INP-1439 - The "m:OnAfterConfigRead" event isn't fired during url processing to INP-1439 - Fire "m:OnAfterConfigRead" event during Url Processing.Jul 16 2016, 7:17 AM