Differential D89

INP-1441 - Fix JavaScript error during link editing in the CKEditor
ClosedPublic
Actions

Authored by alex on Jul 24 2015, 11:29 AM.

Details

Reviewers

glebs

Commits

rINP16262: Fixes INP-1441 - JavaScript error, when editing link in CKEditor

Test Plan

open website in Content Mode
edit content any block and type this in it (view Source toolbar button in CKEditor): aa <a class="cc" href="#" title="tt">link</a> bb
save content block
edit that content block again and this time:
- click on the link
- right click on the link
- select Edit Link menu item
confirm, that no JS error has happened at this point

Diff Detail

Repository

rINP In-Portal

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex updated this revision to Diff 223.Jul 24 2015, 11:29 AM

alex retitled this revision from to INP-1441 - JavaScript error, when editing link in CKEditor.

alex updated this object.

alex edited the test plan for this revision. (Show Details)

alex added 1 JIRA issue(s): INP-1441.

Herald added a reviewer: glebs. · View Herald TranscriptJul 24 2015, 11:29 AM

glebs accepted this revision.Sep 7 2015, 1:37 AM

glebs edited edge metadata.

This revision is now accepted and ready to land.Sep 7 2015, 1:37 AM

Closed by commit rINP16262: Fixes INP-1441 - JavaScript error, when editing link in CKEditor (authored by alex). · Explain WhySep 27 2015, 3:16 AM

This revision was automatically updated to reflect the committed changes.

alex edited edge metadata.Mar 10 2016, 5:52 AM

alex added a project: Restricted Project.

alex retitled this revision from INP-1441 - JavaScript error, when editing link in CKEditor to INP-1441 - Fix JavaScript error during link editing in the CKEditor.Jul 16 2016, 7:16 AM

Revision Contents
Changeset List

			Path	Packages
M			branches/5.2.x/core/ckeditor/plugins/my_link/plugin.js (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	223	16200		Jul 24 2015, 11:29 AM	★	★
Diff 2	326	16261	Commit rINP16262	Sep 27 2015, 3:16 AM	★	★

Diff 326

View Options

branches/5.2.x/core/ckeditor/plugins/my_link/plugin.js

INP-1441 - Fix JavaScript error during link editing in the CKEditorClosedPublicActions