Differential D144

INP-1492 - Replace "%2$s" with current language in "kDBList::extractCalculatedFields" method
ClosedPublic
Actions

Authored by alex on Oct 3 2015, 5:39 AM.

Details

Reviewers

glebs

Commits

rINP16298: Fixes INP-1492 - Replace "%2$s" with current language in "kDBList…

Test Plan

in PhpStorm:
1. comment out the di:OnAfterConfigRead event
2. change ItemName calculated field (of di unit) declaration into 'IF(p.Name IS NULL,c.l%2$s_Name,p.l%2$s_Name)'
in Admin Console:
1. go to E-commerce → Discounts & Certificates section
2. create discount, that has 1 product
3. confirm, that product name is displayed correctly on Items tab during discount editing
4. use Item Name column filter to search for letter present in product name
5. confirm, that product is displayed and no SQL error present in Debugger
6. use Item Name column filter to search for letter not present in product name
7. confirm, that product isn't displayed and no SQL error present in Debugger
8. remove grid search filter
in PhpStorm:
1. create the DiscountItemsEventHandler::SetCustomQuery method in which apply HAVING filter to the ItemName column (e.g. $object->addFilter('test_filter', 'ItemName LIKE ' . $this->Conn->qstr('z'), kDBList::HAVING_FILTER);)
2. confirm, that no SQL error happens and data is filtered as expected

Diff Detail

Repository

rINP In-Portal

Branch

/in-portal/branches/5.2.x

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 199
Build 199: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 357.Oct 3 2015, 5:39 AM

alex retitled this revision from to INP-1492 - Replace "%2$s" with current language in "kDBList::extractCalculatedFields" method.

alex updated this object.

alex edited the test plan for this revision. (Show Details)

alex added 1 JIRA issue(s): INP-1492.

Herald added a reviewer: glebs. · View Herald TranscriptOct 3 2015, 5:39 AM

glebs accepted this revision.Oct 6 2015, 1:55 AM

glebs edited edge metadata.

This revision is now accepted and ready to land.Oct 6 2015, 1:55 AM

Closed by commit rINP16298: Fixes INP-1492 - Replace "%2$s" with current language in "kDBList… (authored by alex). · Explain WhyOct 25 2015, 1:18 PM

This revision was automatically updated to reflect the committed changes.

alex edited edge metadata.Mar 10 2016, 5:42 AM

alex added a project: Restricted Project.

Revision Contents
Changeset List

			Path	Packages
M			core/kernel/db/dblist.php (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	357	16284		Oct 3 2015, 5:39 AM	★	★
Diff 2	390	16297	Commit rINP16298	Oct 25 2015, 1:18 PM	★	★

Commit	Parents	Author	Summary	Date
#fake-hash			Ignore it :) (Show More…)

Diff 357

View Options

INP-1492 - Replace "%2$s" with current language in "kDBList::extractCalculatedFields" methodClosedPublicActions