Unexpected output: Affected paths: relative - resubmit patch.
⚙ D146 INP-1494 - Create "phing:run" console command
Page MenuHomeIn-Portal Phabricator

INP-1494 - Create "phing:run" console command
Changes PlannedPublic

Authored by alex on Oct 4 2015, 3:53 PM.

Details

Reviewers
erik
Test Plan
NOTE: Run source tools/bash_completion.sh to enable Bash auto-complete.
NOTE: If tools/build/build.properties file is missing create it based on build.properties.dist file and fill all missing values.

Part 1

  1. make sure, that Phing is installed (see https://www.phing.info/)
  2. run the in-portal classmap:rebuild command
  3. type in-portal then space and then press TAB two times
  4. confirm, that phing:run command is auto-completed
  5. run in-portal command
  6. confirm, that phing:run command is listed in the output

Part 2

  1. delete /system/phing_settings.json file if present
  2. type in-portal phing:run then space and then press TAB two times
  3. confirm, that all Phing targets are shown in auto-complete results are shown

Part 3

  1. delete /system/phing_settings.json file if present
  2. run in-portal phing:run command
  3. confirm, that user is presented with a choice to select build file
  4. choose non existing build file
  5. confirm, that error message is displayed
  6. choose existing build file by pressing matching number (e.g. 0 or 1)
  7. confirm, that following is shown:
    • location of previously chosen build file
    • possible Phing commands with their descriptions
  8. run in-portal phing:run command
  9. confirm that:
    • user isn't asked for a build file
    • location of previously chosen build file is displayed
    • possible Phing commands with their descriptions is displayed

Part 4

  1. run the in-portal phing:run lint command
  2. confirm, that command does check syntax errors in ALL php files in the project
  3. run the in-portal phing:run phpcs core/kernel/globals.php command
  4. confirm, that code style issues were checked only at specified path
  5. type in-portal phing:run phpcs then space and press TAB two times
  6. confirm, that folders/files at root of In-Portal directory are shown

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.3.x
Lint
Lint ErrorsExcuse: License-related issues will be fixed separately. Other issues can't be fixed at all.
SeverityLocationCodeMessage
Errorcore/kernel/Console/Command/RunPhingCommand.php:2PHPCS.E.CodingStandard.Commenting.DocComment.MissingShortCodingStandard.Commenting.DocComment.MissingShort
Errorcore/kernel/Console/Command/RunPhingCommand.php:3PHPCS.E.Squiz.Commenting.DocCommentAlignment.SpaceBeforeStarSquiz.Commenting.DocCommentAlignment.SpaceBeforeStar
Errorcore/kernel/Console/Command/RunPhingCommand.php:4PHPCS.E.Squiz.Commenting.DocCommentAlignment.SpaceBeforeStarSquiz.Commenting.DocCommentAlignment.SpaceBeforeStar
Errorcore/kernel/Console/Command/RunPhingCommand.php:5PHPCS.E.Squiz.Commenting.DocCommentAlignment.SpaceBeforeStarSquiz.Commenting.DocCommentAlignment.SpaceBeforeStar
Errorcore/kernel/Console/Command/RunPhingCommand.php:6PHPCS.E.Squiz.Commenting.DocCommentAlignment.SpaceBeforeStarSquiz.Commenting.DocCommentAlignment.SpaceBeforeStar
Errorcore/kernel/Console/Command/RunPhingCommand.php:7PHPCS.E.Squiz.Commenting.DocCommentAlignment.SpaceBeforeStarSquiz.Commenting.DocCommentAlignment.SpaceBeforeStar
Errorcore/kernel/Console/Command/RunPhingCommand.php:8PHPCS.E.Squiz.Commenting.DocCommentAlignment.SpaceBeforeStarSquiz.Commenting.DocCommentAlignment.SpaceBeforeStar
Errorcore/kernel/Console/Command/RunPhingCommand.php:9PHPCS.E.Squiz.Commenting.DocCommentAlignment.SpaceBeforeStarSquiz.Commenting.DocCommentAlignment.SpaceBeforeStar
Errorcore/kernel/Console/Command/RunPhingCommand.php:10PHPCS.E.Squiz.Commenting.DocCommentAlignment.SpaceBeforeStarSquiz.Commenting.DocCommentAlignment.SpaceBeforeStar
Errorcore/kernel/Console/Command/RunPhingCommand.php:11PHPCS.E.Squiz.Commenting.DocCommentAlignment.SpaceBeforeStarSquiz.Commenting.DocCommentAlignment.SpaceBeforeStar
Errorcore/kernel/Console/Command/RunPhingCommand.php:12PHPCS.E.Squiz.Commenting.DocCommentAlignment.SpaceBeforeStarSquiz.Commenting.DocCommentAlignment.SpaceBeforeStar
Errorcore/kernel/Console/Command/RunPhingCommand.php:13PHPCS.E.Squiz.Commenting.DocCommentAlignment.SpaceBeforeStarSquiz.Commenting.DocCommentAlignment.SpaceBeforeStar
Errorcore/kernel/Console/Command/RunPhingCommand.php:164PHPCS.E.CodingStandard.NamingConventions.ValidVariableName.NotSnakeCapsCodingStandard.NamingConventions.ValidVariableName.NotSnakeCaps
Errorcore/kernel/Console/Command/RunPhingCommand.php:166PHPCS.E.CodingStandard.NamingConventions.ValidVariableName.NotSnakeCapsCodingStandard.NamingConventions.ValidVariableName.NotSnakeCaps
Errorcore/kernel/Console/Command/RunPhingCommand.php:168PHPCS.E.CodingStandard.NamingConventions.ValidVariableName.NotSnakeCapsCodingStandard.NamingConventions.ValidVariableName.NotSnakeCaps
Errorcore/kernel/Console/PhingCache.php:2PHPCS.E.CodingStandard.Commenting.DocComment.MissingShortCodingStandard.Commenting.DocComment.MissingShort
Errorcore/kernel/Console/PhingCache.php:3PHPCS.E.Squiz.Commenting.DocCommentAlignment.SpaceBeforeStarSquiz.Commenting.DocCommentAlignment.SpaceBeforeStar
Errorcore/kernel/Console/PhingCache.php:4PHPCS.E.Squiz.Commenting.DocCommentAlignment.SpaceBeforeStarSquiz.Commenting.DocCommentAlignment.SpaceBeforeStar
Errorcore/kernel/Console/PhingCache.php:5PHPCS.E.Squiz.Commenting.DocCommentAlignment.SpaceBeforeStarSquiz.Commenting.DocCommentAlignment.SpaceBeforeStar
Errorcore/kernel/Console/PhingCache.php:6PHPCS.E.Squiz.Commenting.DocCommentAlignment.SpaceBeforeStarSquiz.Commenting.DocCommentAlignment.SpaceBeforeStar
Errorcore/kernel/Console/PhingCache.php:7PHPCS.E.Squiz.Commenting.DocCommentAlignment.SpaceBeforeStarSquiz.Commenting.DocCommentAlignment.SpaceBeforeStar
Errorcore/kernel/Console/PhingCache.php:8PHPCS.E.Squiz.Commenting.DocCommentAlignment.SpaceBeforeStarSquiz.Commenting.DocCommentAlignment.SpaceBeforeStar
Errorcore/kernel/Console/PhingCache.php:9PHPCS.E.Squiz.Commenting.DocCommentAlignment.SpaceBeforeStarSquiz.Commenting.DocCommentAlignment.SpaceBeforeStar
Errorcore/kernel/Console/PhingCache.php:10PHPCS.E.Squiz.Commenting.DocCommentAlignment.SpaceBeforeStarSquiz.Commenting.DocCommentAlignment.SpaceBeforeStar
Errorcore/kernel/Console/PhingCache.php:11PHPCS.E.Squiz.Commenting.DocCommentAlignment.SpaceBeforeStarSquiz.Commenting.DocCommentAlignment.SpaceBeforeStar
Unit
No Unit Test Coverage
Build Status
Buildable 202
Build 202: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 360.Oct 4 2015, 3:53 PM
alex retitled this revision from to INP-1494 - Create "phing:run" console command.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1494.
alex edited the test plan for this revision. (Show Details)Oct 4 2015, 3:54 PM
alex edited edge metadata.
alex planned changes to this revision.EditedOct 6 2015, 4:23 AM

@glebs, please do not test this yet, because I had some changes in mind.

TODO:

  1. validate, that /usr/local/bin/composer file is present and is working Composer installation (if missing suggest installing it OR symlinking from location where it's installed)
  2. auto-create (if missing) the /tools/build/build.properties file by copying the /tools/build/build.properties.dist and filling missing pieces from /system/config.php file (if later is missing throw exception that In-Portal is most likely not installed)
  3. in error about missing Phing show URL to Phing website, that has installation instructions
alex edited reviewers, added: erik; removed: glebs.Jun 20 2016, 5:02 AM