After dropping search result table it is recreated with no records in it.
Details
Details
- select advanced theme
- go to front end
- make search with empty keyword or short keyword
- confirm getting "The keyword is too short!" warning
- make search with keyword, matching category name or category item name
- confirm getting relevant search results
- make search with empty keyword or short keyword
- confirm getting "The keyword is too short!" warning
- make search with long keyword, matching no category and no category item
- confirm getting "Nothing Found!" warning
Diff Detail
Diff Detail
- Repository
- rINP In-Portal
- Branch
- /in-portal/branches/5.2.x
- Lint
Lint Errors Excuse: Search helper re-formatting is not a part of this task. Severity Location Code Message Error core/units/helpers/search_helper.php:837 PHPCS.E.CodingStandard.Classes.ClassDeclaration.SpaceBeforeCloseBrace CodingStandard.Classes.ClassDeclaration.SpaceBeforeCloseBrace - Unit
No Unit Test Coverage - Build Status
Buildable 216 Build 216: arc lint + arc unit
Event Timeline
Comment Actions
Also test plan doesn't cover code path, that caused search table removal in past (e.g. make search that finds something and then make search with short/empty keyword).
| core/kernel/db/cat_event_handler.php | ||
|---|---|---|
| 1242 | Please don't remove this comment. | |
| core/units/categories/categories_event_handler.php | ||
| 2588 | Please don't remove this comment. | |
| core/units/helpers/search_helper.php | ||
| 832 | Please:
There are still 8 places, where search table name is still built manually (not via this method). | |