Unexpected output: Affected paths: relative - resubmit patch.
⚙ D167 INP-1514 Reset validation errors before object loading
Page MenuHomeIn-Portal Phabricator

INP-1514 Reset validation errors before object loading
ClosedPublic

Authored by erik on Nov 16 2015, 4:33 AM.

Details

Summary

call the "kDBItem::Clear" method at the beginning of "kDBItem::Load" method

Test Plan
WARNING: Apply patch from D160 revision before testing this patch.
  1. go to ToolsQuery Database section
  2. run SQL like: UPDATE inp_Categories SET l1_Name = '' WHERE l1_Name = 'Home' to break validation for some category in the middle of categories grid, displayed on Website & ContentStructure & Data
  3. go to Website & ContentStructure & Data
  4. confirm, that some category with status Active in the middle of the list have empty "Section Title" field
  5. select some categories with status Active, including category with empty "Section Title" field, some category before it and some category after it in the grid
  6. confirm that pressing Decline button do not change Status for category with empty name, and correctly change statuses for other selected categories, and no fatal error happens
  7. restore category name(s) and statuses, changed in this test

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 255
Build 255: arc lint + arc unit

Event Timeline

erik updated this revision to Diff 413.Nov 16 2015, 4:33 AM
erik retitled this revision from to INP-1514 Reset validation errors before object loading.
erik updated this object.
erik edited the test plan for this revision. (Show Details)
erik added a reviewer: alex.
erik added 1 JIRA issue(s): INP-1514.
erik edited the test plan for this revision. (Show Details)Nov 16 2015, 4:39 AM
alex edited the test plan for this revision. (Show Details)Nov 17 2015, 2:34 AM
alex edited the test plan for this revision. (Show Details)
alex accepted this revision.Nov 17 2015, 3:11 AM
alex edited the test plan for this revision. (Show Details)
alex edited the test plan for this revision. (Show Details)
alex edited edge metadata.
This revision is now accepted and ready to land.Nov 17 2015, 3:12 AM
This revision was automatically updated to reflect the committed changes.
alex edited edge metadata.Mar 10 2016, 5:35 AM
alex added a project: Restricted Project.