Differential D181

INP-1525 - Register default build events when re-reading caches
ClosedPublic
Actions

Authored by alex on Dec 11 2015, 11:25 AM.

Details

Reviewers

glebs

Commits

rINP16318: Fixes INP-1525 - Register default build events when re-reading caches

Test Plan

go to Admin Console
go to Website & Content → Labels & Phrases section
from command line make a deploy via do_update script
in Admin Console open phrase for editing
confirm, that no SQL error happened

Diff Detail

Repository

rINP In-Portal

Branch

/in-portal/branches/5.2.x

Lint

Lint Errors

Excuse: Won't be fixing in 5.2.x.

Severity	Location	Code	Message
Error	core/kernel/application.php:760	PHPCS.E.CodingStandard.NamingConventions.ValidFunctionName.ScopeNotCamelCaps	CodingStandard.NamingConventions.ValidFunctionName.ScopeNotCamelCaps

Unit

No Unit Test Coverage

Build Status

Buildable 276
Build 276: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 432.Dec 11 2015, 11:25 AM

alex retitled this revision from to INP-1525 - Register default build events when re-reading caches.

alex updated this object.

alex edited the test plan for this revision. (Show Details)

alex added 1 JIRA issue(s): INP-1525.

Herald added a reviewer: glebs. · View Herald TranscriptDec 11 2015, 11:25 AM

glebs accepted this revision.Dec 24 2015, 3:27 AM

glebs edited edge metadata.

This revision is now accepted and ready to land.Dec 24 2015, 3:27 AM

Closed by commit rINP16318: Fixes INP-1525 - Register default build events when re-reading caches (authored by alex). · Explain WhyJan 17 2016, 7:24 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	432	16303		Dec 11 2015, 11:25 AM	★	★
Diff 2	453	16317	Commit rINP16318	Jan 17 2016, 7:24 AM	★	★

Commit	Parents	Author	Summary	Date
#fake-hash			Ignore it :) (Show More…)

Diff 432

View Options

core/kernel/application.php