Unexpected output: Affected paths: relative - resubmit patch.
⚙ D226 INP-1552 Import language pack without overwrite on separate module install
Page MenuHomeIn-Portal Phabricator
Differential D226

INP-1552 Import language pack without overwrite on separate module install
ClosedPublic
Actions

Authored by glebs on May 19 2016, 3:00 AM.

Details

Reviewers
alex
Commits
rMINC16489: Bug INP-1552 - Import language pack without overwrite on separate module install
rMINL16486: Bug INP-1552 - Import language pack without overwrite on separate module install
rMCUS16485: Fixes INP-1552 - Import language pack without overwrite on separate module…
rMINN16487: Fixes INP-1552 - Import language pack without overwrite on separate module…
rMINB16488: Bug INP-1552 - Import language pack without overwrite on separate module install
Test Plan
NOTE: Repeat all of below for each module separately.

Preparations

  1. open modules/in-link/install/english.lang file for еditing
  2. add next line as first element of <PHRASES> tag:
<PHRASE Label="la_ToolTip_New_Category" Module="Core" Type="1">TmV3IENhdGVnb3J5</PHRASE>

Testing installing In-Portal with modules (should overwrite language pack)

  1. do clean install of In-Portal 5.2 with In-Link module
  2. login to Admin Console as root user
  3. go to Website & Content → Structure & Data section
  4. confirm that sections grid toolbar has a New Category button instead of New Section (renamed in In-Link module)

Testing separated module installation (should not overwrite language pack)

  1. do clean install of In-Portal 5.2 without additional modules
  2. login to Admin Console as root user
  3. go to Website & Content → Structure & Data section
  4. confirm that sections grid toolbar has a New Section button
  5. go to Configuration → Website → Modules section
  6. click Install link for In-Link module and wait while module will be installed
  7. go to Website & Content → Structure & Data section
  8. confirm that New Section button on sections grid toolbar isn't renamed

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint ErrorsExcuse: Errors not related to changed lines or breaks BC
SeverityLocationCodeMessage
Errorcore/install.php:885PHPCS.E.CodingStandard.Commenting.InlineComment.InvalidEndCharCodingStandard.Commenting.InlineComment.InvalidEndChar
Errorcore/install.php:885PHPCS.E.CodingStandard.Commenting.InlineComment.NotCapitalCodingStandard.Commenting.InlineComment.NotCapital
Errorcore/install.php:1009PHPCS.E.CodingStandard.Commenting.InlineComment.InvalidEndCharCodingStandard.Commenting.InlineComment.InvalidEndChar
Errorcore/install.php:1009PHPCS.E.CodingStandard.Commenting.InlineComment.NotCapitalCodingStandard.Commenting.InlineComment.NotCapital
Errorcore/install/install_toolkit.php:430PHPCS.E.CodingStandard.Commenting.FunctionComment.MissingReturnCodingStandard.Commenting.FunctionComment.MissingReturn
Errorcore/install/install_toolkit.php:431PHPCS.E.CodingStandard.NamingConventions.ValidFunctionName.ScopeNotCamelCapsCodingStandard.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
Unit
No Unit Test Coverage
Build Status
Buildable 388
Build 388: arc lint + arc unit

Event Timeline

glebs updated this revision to Diff 528.May 19 2016, 3:00 AM
glebs retitled this revision from to INP-1552 Import language pack without overwrite on separate module install.
glebs updated this object.
glebs edited the test plan for this revision. (Show Details)
glebs added 1 JIRA issue(s): INP-1552.
glebs edited the test plan for this revision. (Show Details)May 19 2016, 3:01 AM
glebs edited edge metadata.
glebs edited the test plan for this revision. (Show Details)
glebs edited the test plan for this revision. (Show Details)
alex edited the test plan for this revision. (Show Details)May 19 2016, 4:04 AM
alex edited the test plan for this revision. (Show Details)
alex edited the test plan for this revision. (Show Details)May 19 2016, 4:06 AM
alex requested changes to this revision.May 19 2016, 4:14 AM
alex edited edge metadata.

Right now, when installing In-Portal with modules in one go no language pack overwrite happened.

I certainly haven't requested this side effect in task.

This revision now requires changes to proceed.May 19 2016, 4:14 AM
glebs edited the test plan for this revision. (Show Details)May 26 2016, 1:50 AM
glebs edited edge metadata.
glebs updated this revision to Diff 529.May 26 2016, 1:54 AM
glebs edited edge metadata.

Overwrite language pack on in-portal install, but do not on separate module install

alex requested changes to this revision.May 26 2016, 2:27 AM
alex edited edge metadata.
alex added inline comments.
core/install/install_toolkit.php
99

Please revert changes to this file.

modules/custom/install.php
19 ↗(On Diff #529)
NOTE: Repeat for other install.php files.

Please revert these changes.

36 ↗(On Diff #529)
NOTE: Repeat for other install.php files.

Specify isset($constants_file) as 2nd argument.

This straightforward way. In your version you're specifying a flag to kInstallToolkit class, that it will use in non obvious way when ImportLanguage method would be called from it.

This revision now requires changes to proceed.May 26 2016, 2:27 AM
glebs updated this revision to Diff 530.May 27 2016, 2:02 AM
glebs edited edge metadata.

Requested changes

alex edited the test plan for this revision. (Show Details)May 27 2016, 2:19 AM
alex edited edge metadata.
alex edited the test plan for this revision. (Show Details)Nov 19 2016, 8:08 AM
alex accepted this revision.Nov 19 2016, 8:10 AM
alex edited edge metadata.
This revision is now accepted and ready to land.Nov 19 2016, 8:10 AM
Closed by commit rMCUS16485: Fixes INP-1552 - Import language pack without overwrite on separate module… (authored by alex). · Explain WhyNov 25 2016, 8:13 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 152816347May 19 2016, 3:00 AM
★
★
Diff 252916347Overwrite language pack on in-portal install, but do not on separate module installMay 26 2016, 1:54 AM
★
★
Diff 353016347Requested changesMay 27 2016, 2:02 AM
★
★
Diff 465116450rMCUS16485Nov 25 2016, 8:13 AM
★
★

Diff 528

View Options

core/install.php

Loading...
View Options

core/install/install_toolkit.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server