Unexpected output: Affected paths: relative - resubmit patch.
⚙ D233 MINC-176 - Register missing classes in class factory
Page MenuHomeIn-Portal Phabricator
Differential D233

MINC-176 - Register missing classes in class factory
ClosedPublic
Actions

Authored by alex on Jul 8 2016, 3:03 PM.

Details

Reviewers
erik
Commits
rMINC16378: Fixes MINC-176 - Register missing classes in class factory
Test Plan

Preparations

  1. Admin Console
    • go to Website & Content → Structure & Data → Products section
    • click on Sections tab
    • use New Section toolbar button to create Sub Products section
    • go to Website & Content → Structure & Data → Products → Sub Products section
    • click on Products tab
    • use New Product toolbar button to create new service product with non-zero price
    • if product was created with 0 price, then edit it again and set non-zero price
    • use New Product toolbar button to create new tangible product with non-zero price
    • go to Configuration → E-commerce → Payment Types section
    • select Credit Card (manual) payment type
    • press Set Primary toolbar button
    • go to Configuration → E-commerce → Shipping section
    • click on Custom Shipping Types tab
    • use Add button to create new shipping type, that would cover all zones and have handling type
  2. IDE:

Part 1 (debug only credit card numbers)

  1. in IDE
    • change \kGWBase::gettestccnumbers method (file: /modules/in-commerce/units/gateways/gw_classes/gw_base.php) to return array('4222222222222');
    • enable both DEBUG_MODE and DBG_PAYMENT_GW options in $dbg_options array in /system/debug.php file
  2. On Front-End
    • click on Products → Sub Products item in top menu
    • confirm, that created before service product is displayed
    • click on Buy Now button next to service product created above
    • confirm, that redirect to Shopping Cart page happened
    • click on Proceed to Checkout button at below the cart
    • confirm, that redirect to billing page happened
    • type xx into Credit Card Number field and press Proceed to preview button
    • confirm, that Credit card number is invalid error is shown above Credit Card Number field
    • type 4222222222222 into Credit Card Number field and press Proceed to preview button
    • confirm, that no error is shown above Credit Card Number field

Part 2 (card charging, form tags)

  1. On Front-End
    • click on Products → Sub Products item in top menu
    • confirm, that created before service product is displayed
    • click on Buy Now button next to service product created above
    • confirm, that redirect to Shopping Cart page happened
    • click on Proceed to Checkout button at below the cart
    • confirm, that redirect to billing page happened
    • fill all required fields on them form and press Proceed to preview button
    • confirm, that redirect to preview page happened
    • press Place Order button
    • confirm, that redirect to thank you page happened

Part 3 (approving order)

  1. On Front-End
    • repeat all steps from Part 2 of test plan
  2. In Admin Console
    • go to E-commerce → Orders section
    • click on Pending tab
    • select order, that was created on Front-End
    • press Approve toolbar button
    • confirm, that order was moved from Pending into Processed tab

Part 4 (denying order)

  1. On Front-End
    • repeat all steps from Part 2 of test plan
  2. In Admin Console
    • go to E-commerce → Orders section
    • click on Pending tab
    • select order, that was created on Front-End
    • press Deny toolbar button
    • confirm, that order was moved from Pending into Denied tab

Part 5 (shipping order)

  1. On Front-End
    • click on Products → Sub Products item in top menu
    • confirm, that created before tangible product is displayed
    • click on Buy Now button next to tangible product created above
    • confirm, that redirect to Shopping Cart page happened
    • click on Proceed to Checkout button at below the cart
    • confirm, that redirect to shipping page happened
    • fill required form fields and "Shipping Email" field
    • press Update Address button
    • confirm, that shipping types appeared at form bottom
    • press Proceed to Billing button
    • confirm, that redirect to billing page happened
    • fill all required fields on them form and press Proceed to preview button
    • confirm, that redirect to preview page happened
    • press Place Order button
    • confirm, that redirect to thank you page happened
  2. In Admin Console
    • go to E-commerce → Orders section
    • click on Pending tab
    • select order, that was created on Front-End
    • press Approve toolbar button
    • confirm, that order was moved from Pending into To Ship tab
    • go to To Ship tab
    • select order, that was created on Front-End
    • press Ship toolbar button
    • confirm, that order was moved from To Ship into Processed tab

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint ErrorsExcuse: Unit configs are mass-fixed in 5.3.x.
SeverityLocationCodeMessage
Errormodules/in-commerce/units/gateways/gateways_config.php:21PHPCS.E.CodingStandard.Formatting.ItemAssignment.MixedWhitespaceAfterCodingStandard.Formatting.ItemAssignment.MixedWhitespaceAfter
Errormodules/in-commerce/units/gateways/gateways_config.php:21PHPCS.E.CodingStandard.Formatting.ItemAssignment.NoSpacingAfterCodingStandard.Formatting.ItemAssignment.NoSpacingAfter
Errormodules/in-commerce/units/gateways/gateways_config.php:21PHPCS.E.CodingStandard.Formatting.ItemAssignment.NoSpacingAfterCodingStandard.Formatting.ItemAssignment.NoSpacingAfter
Errormodules/in-commerce/units/gateways/gateways_config.php:21PHPCS.E.CodingStandard.Formatting.ItemAssignment.NoSpacingAfterCodingStandard.Formatting.ItemAssignment.NoSpacingAfter
Errormodules/in-commerce/units/gateways/gateways_config.php:21PHPCS.E.CodingStandard.Formatting.ItemAssignment.NoSpacingBeforeCodingStandard.Formatting.ItemAssignment.NoSpacingBefore
Errormodules/in-commerce/units/gateways/gateways_config.php:21PHPCS.E.CodingStandard.Formatting.ItemAssignment.NoSpacingBeforeCodingStandard.Formatting.ItemAssignment.NoSpacingBefore
Errormodules/in-commerce/units/gateways/gateways_config.php:21PHPCS.E.CodingStandard.Formatting.ItemAssignment.NoSpacingBeforeCodingStandard.Formatting.ItemAssignment.NoSpacingBefore
Errormodules/in-commerce/units/gateways/gateways_config.php:21PHPCS.E.CodingStandard.WhiteSpace.CommaSpacing.AfterCodingStandard.WhiteSpace.CommaSpacing.After
Errormodules/in-commerce/units/gateways/gateways_config.php:21PHPCS.E.CodingStandard.WhiteSpace.CommaSpacing.AfterCodingStandard.WhiteSpace.CommaSpacing.After
Errormodules/in-commerce/units/gateways/gateways_config.php:21PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errormodules/in-commerce/units/gateways/gateways_config.php:21PHPCS.E.Squiz.WhiteSpace.OperatorSpacing.NoSpaceAfterSquiz.WhiteSpace.OperatorSpacing.NoSpaceAfter
Errormodules/in-commerce/units/gateways/gateways_config.php:21PHPCS.E.Squiz.WhiteSpace.OperatorSpacing.NoSpaceAfterSquiz.WhiteSpace.OperatorSpacing.NoSpaceAfter
Errormodules/in-commerce/units/gateways/gateways_config.php:21PHPCS.E.Squiz.WhiteSpace.OperatorSpacing.NoSpaceAfterSquiz.WhiteSpace.OperatorSpacing.NoSpaceAfter
Errormodules/in-commerce/units/gateways/gateways_config.php:21PHPCS.E.Squiz.WhiteSpace.OperatorSpacing.NoSpaceBeforeSquiz.WhiteSpace.OperatorSpacing.NoSpaceBefore
Errormodules/in-commerce/units/gateways/gateways_config.php:21PHPCS.E.Squiz.WhiteSpace.OperatorSpacing.NoSpaceBeforeSquiz.WhiteSpace.OperatorSpacing.NoSpaceBefore
Errormodules/in-commerce/units/gateways/gateways_config.php:21PHPCS.E.Squiz.WhiteSpace.OperatorSpacing.NoSpaceBeforeSquiz.WhiteSpace.OperatorSpacing.NoSpaceBefore
Errormodules/in-commerce/units/gateways/gateways_config.php:21PHPCS.E.Squiz.WhiteSpace.OperatorSpacing.SpacingAfterSquiz.WhiteSpace.OperatorSpacing.SpacingAfter
Errormodules/in-commerce/units/gateways/gateways_config.php:40PHPCS.E.CodingStandard.Formatting.ItemAssignment.MixedWhitespaceAfterCodingStandard.Formatting.ItemAssignment.MixedWhitespaceAfter
Errormodules/in-commerce/units/gateways/gateways_config.php:40PHPCS.E.CodingStandard.Formatting.ItemAssignment.MixedWhitespaceBeforeCodingStandard.Formatting.ItemAssignment.MixedWhitespaceBefore
Errormodules/in-commerce/units/gateways/gateways_config.php:40PHPCS.E.CodingStandard.Formatting.SpaceOperator.SpacingBeforeCodingStandard.Formatting.SpaceOperator.SpacingBefore
Errormodules/in-commerce/units/gateways/gateways_config.php:40PHPCS.E.Squiz.WhiteSpace.OperatorSpacing.SpacingAfterSquiz.WhiteSpace.OperatorSpacing.SpacingAfter
Errormodules/in-commerce/units/gateways/gateways_config.php:74PHPCS.E.CodingStandard.Commenting.InlineComment.InvalidEndCharCodingStandard.Commenting.InlineComment.InvalidEndChar
Errormodules/in-commerce/units/gateways/gateways_config.php:74PHPCS.E.CodingStandard.Commenting.InlineComment.NotCapitalCodingStandard.Commenting.InlineComment.NotCapital
Errormodules/in-commerce/units/gateways/gateways_config.php:76PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeywordCodingStandard.Array.Array.SpaceAfterKeyword
Errormodules/in-commerce/units/gateways/gateways_config.php:76PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Unit
No Unit Test Coverage
Build Status
Buildable 407
Build 407: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 546.Jul 8 2016, 3:03 PM
alex retitled this revision from to MINC-176 - Register missing classes in class factory.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): MINC-176.
alex edited the test plan for this revision. (Show Details)Jul 8 2016, 3:04 PM
alex edited edge metadata.
alex updated this revision to Diff 547.Jul 8 2016, 3:07 PM

Fixing CS issues in added lines.

erik requested changes to this revision.Jul 11 2016, 4:35 AM
erik edited edge metadata.
  1. Can't "confirm, that redirect to thank you page happened", as written in test plan. When not logged in front-end user performs "Place Order" operation, happens redirect to registration page, not to thank you page.
  2. Seems, test plan is incomplete - last line (press Ship toolbar button) requests test action, but no confirmation line following.
  3. Performing that "press Ship toolbar button" results in "mail error: header To is required" exception - http://screencast.com/t/ahSVogRnph6
This revision now requires changes to proceed.Jul 11 2016, 4:35 AM
alex edited the test plan for this revision. (Show Details)Jul 11 2016, 4:38 AM
alex edited edge metadata.
alex requested a review of this revision.EditedJul 11 2016, 5:30 AM
alex edited edge metadata.
  1. Can't "confirm, that redirect to thank you page happened", as written in test plan. When not logged in front-end user performs "Place Order" operation, happens redirect to registration page, not to thank you page.

This is thank you page. On top there is small text telling user, that order was created and then there is large registration form.

  1. Seems, test plan is incomplete - last line (press Ship toolbar button) requests test action, but no confirmation line following.

Acknowledged. Test plan updated.

  1. Performing that "press Ship toolbar button" results in "mail error: header To is required" exception - http://screencast.com/t/ahSVogRnph6

Thanks for finding. Issue is not related and was reported in http://jira.in-portal.org/browse/MINC-178. For now please manually:

  • replace BillingEmail to ShippingEmail on the in-commerce/elements/content_boxes/checkout/shipping_address.elm template of advanced theme
  • remove requirement from BillingEmail field on Shipping checkout step (in OrdersEventHandler::SetStepRequiredFields method)
  • retest
erik accepted this revision.Jul 12 2016, 4:57 AM
erik edited edge metadata.
This revision is now accepted and ready to land.Jul 12 2016, 4:57 AM
alex edited the test plan for this revision. (Show Details)Jul 12 2016, 5:00 AM
alex edited edge metadata.
Closed by commit rMINC16378: Fixes MINC-176 - Register missing classes in class factory (authored by alex). · Explain WhyJul 25 2016, 3:49 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 154616347Jul 8 2016, 3:03 PM
★
★
Diff 254716347Fixing CS issues in added lines.Jul 8 2016, 3:07 PM
★
★
Diff 358216375rMINC16378Jul 25 2016, 3:49 AM
★
★

Diff 547

View Options

modules/in-commerce/units/gateways/gateways_config.php

Loading...
View Options

modules/in-commerce/units/orders/order_validator.php

Loading...
View Options

modules/in-commerce/units/orders/orders_event_handler.php

Loading...
View Options

modules/in-commerce/units/orders/orders_tag_processor.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server