Unexpected output: Affected paths: relative - resubmit patch.
⚙ D234 INP-1570 - Make In-Portal Class Locator externally usable
Page MenuHomeIn-Portal Phabricator

INP-1570 - Make In-Portal Class Locator externally usable
ClosedPublic

Authored by alex on Jul 10 2016, 5:06 AM.

Details

Test Plan

Part 1 (removed "st" unit files)

  1. in Admin Console:
    • go to Website & ContentBrowse Website section
    • click on Content Mode button in top frame
    • confirm, that:
      • green Section Properties button is now shown
      • orange Edit Content button is now shown
      • no error/exception happened
    • click on Section Properties button
    • confirm, that editing window was opened
    • go to Website & ContentStructure & Data section
    • click on Sections tab
    • confirm, that categories were shown

Part 2 (class locator)

  1. in IDE create /locator_test.php file with following content:
<?php

/** @var callable $locator */
$locator = require 'tools/class_locator.php';

echo 'In-Portal: ' . $locator('kPlainUrlProcessor') . PHP_EOL;
echo 'Composer: ' . $locator('\QATools\QATools\PageObject\Page') . PHP_EOL;
echo 'Missing: ' . $locator('UnknownClass') . PHP_EOL;
  1. run php locator_test.php file from command line
  2. confirm, that output was following (replace ... with absolute path to In-Portal):
In-Portal: .../core/kernel/managers/plain_url_processor.php
Composer: .../vendor/qa-tools/qa-tools/library/QATools/QATools/PageObject/Page.php
Missing:

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint ErrorsExcuse: Will be fixed in 5.3.x.
SeverityLocationCodeMessage
Errorcore/units/structure/structure_config.php:17PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeywordCodingStandard.Array.Array.SpaceAfterKeyword
Errorcore/units/structure/structure_config.php:17PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/structure/structure_config.php:19PHPCS.E.CodingStandard.Formatting.SpaceOperator.SpacingBeforeCodingStandard.Formatting.SpaceOperator.SpacingBefore
Errorcore/units/structure/structure_config.php:20PHPCS.E.CodingStandard.Formatting.SpaceOperator.SpacingBeforeCodingStandard.Formatting.SpaceOperator.SpacingBefore
Errortools/class_locator.php:2PHPCS.E.CodingStandard.Commenting.DocComment.MissingShortCodingStandard.Commenting.DocComment.MissingShort
Errortools/class_locator.php:3PHPCS.E.Squiz.Commenting.DocCommentAlignment.SpaceBeforeStarSquiz.Commenting.DocCommentAlignment.SpaceBeforeStar
Errortools/class_locator.php:4PHPCS.E.Squiz.Commenting.DocCommentAlignment.SpaceBeforeStarSquiz.Commenting.DocCommentAlignment.SpaceBeforeStar
Errortools/class_locator.php:5PHPCS.E.Squiz.Commenting.DocCommentAlignment.SpaceBeforeStarSquiz.Commenting.DocCommentAlignment.SpaceBeforeStar
Errortools/class_locator.php:6PHPCS.E.Squiz.Commenting.DocCommentAlignment.SpaceBeforeStarSquiz.Commenting.DocCommentAlignment.SpaceBeforeStar
Errortools/class_locator.php:7PHPCS.E.Squiz.Commenting.DocCommentAlignment.SpaceBeforeStarSquiz.Commenting.DocCommentAlignment.SpaceBeforeStar
Errortools/class_locator.php:8PHPCS.E.Squiz.Commenting.DocCommentAlignment.SpaceBeforeStarSquiz.Commenting.DocCommentAlignment.SpaceBeforeStar
Errortools/class_locator.php:9PHPCS.E.Squiz.Commenting.DocCommentAlignment.SpaceBeforeStarSquiz.Commenting.DocCommentAlignment.SpaceBeforeStar
Errortools/class_locator.php:10PHPCS.E.Squiz.Commenting.DocCommentAlignment.SpaceBeforeStarSquiz.Commenting.DocCommentAlignment.SpaceBeforeStar
Errortools/class_locator.php:11PHPCS.E.Squiz.Commenting.DocCommentAlignment.SpaceBeforeStarSquiz.Commenting.DocCommentAlignment.SpaceBeforeStar
Errortools/class_locator.php:12PHPCS.E.Squiz.Commenting.DocCommentAlignment.SpaceBeforeStarSquiz.Commenting.DocCommentAlignment.SpaceBeforeStar
Errortools/class_locator.php:13PHPCS.E.Squiz.Commenting.DocCommentAlignment.SpaceBeforeStarSquiz.Commenting.DocCommentAlignment.SpaceBeforeStar
Errortools/class_locator.php:21PHPCS.E.Squiz.WhiteSpace.LanguageConstructSpacing.IncorrectSquiz.WhiteSpace.LanguageConstructSpacing.Incorrect
Unit
No Unit Test Coverage
Build Status
Buildable 408
Build 408: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 548.Jul 10 2016, 5:06 AM
alex retitled this revision from to INP-1570 - Make In-Portal Class Locator externally usable.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1570.
alex edited the test plan for this revision. (Show Details)Jul 10 2016, 5:07 AM
alex edited edge metadata.
alex edited the test plan for this revision. (Show Details)Jul 10 2016, 5:15 AM
erik accepted this revision.Jul 13 2016, 4:47 AM
erik edited edge metadata.
This revision is now accepted and ready to land.Jul 13 2016, 4:47 AM
This revision was automatically updated to reflect the committed changes.