Unexpected output: Affected paths: relative - resubmit patch.
⚙ D245 INP-1447 Remove usage of 'name' parameter in "kDBTagProcessor::GetList" method
Page MenuHomeIn-Portal Phabricator

INP-1447 Remove usage of 'name' parameter in "kDBTagProcessor::GetList" method
ClosedPublic

Authored by erik on Aug 25 2016, 4:18 AM.

Details

Test Plan

Part 1

  1. on Front-End:
    • use Search Box from Sidebar to search for Home keyword
    • confirm, that relevant results appear and contain only Home category
  2. in IDE:
    • open /themes/advanced/platform/elements/content_boxes/search_results.elm.tpl template for editing
    • rename list_name parameter in the c_ListCategories tag to name and save changes
  3. on Front-End
    • reload Search Results page in Web Browser
    • confirm that search results are not relevant to Home keyword (e.g. contains many categories, not only Home category)

Part 2

NOTE: Debug mode must be enabled.
  1. in Admin Console
    • go to User ManagementUsers section
    • create new user
    • go to E-commerceAffiliates
    • create new affiliate using e-mail used during user creation above
    • approve affiliate record using Approve button on toolbar
    • go to User ManagementUsers, select previously created user in the grid
    • press Login As button in toolbar
    • confirm that Front-End was opened in new window/tab
  2. on Front-End (that was opened in new window/tab)
    • click on Affiliate link in the My Account sidebar section
    • confirm that Affiliate Program page is opened
    • click on Affiliate Statistics link in the main page part
    • confirm that Affiliate Statistics page is opened
    • click on Details link in the Total Visitors row
    • confirm that Visitor Statistics page is opened, and no sql error happened
  3. in IDE:
    • open /themes/advanced/in-commerce/my_account/affiliate/affiliate_statistics_visits_list.tpl template for editing
    • rename list_name parameter in the visits_PrintList tag to name and save changes
  4. on Front-End (that was opened in new window/tab)
    • reload Visitor Statistics page in Web Browser
    • confirm that noticed about undefined OrderTotalAmount_SUM and OrderAffiliateCommission_SUM indexes will appear in Debugger

Part 3

  1. in Admin Console
    • go to ConfigurationWebsiteGeneral section
    • confirm, that settings from that section only are displayed

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint ErrorsExcuse: Full file reformatting is not part of this task.
SeverityLocationCodeMessage
Errorcore/units/visits/visits_tag_processor.php:168PHPCS.E.Generic.WhiteSpace.ScopeIndent.IncorrectExactGeneric.WhiteSpace.ScopeIndent.IncorrectExact
Unit
No Unit Test Coverage
Build Status
Buildable 466
Build 466: arc lint + arc unit

Event Timeline

erik updated this revision to Diff 596.Aug 25 2016, 4:18 AM
erik retitled this revision from to INP-1447 Remove usage of 'name' parameter in "kDBTagProcessor::GetList" method.
erik updated this object.
erik edited the test plan for this revision. (Show Details)
erik added a reviewer: alex.
erik added 1 JIRA issue(s): INP-1447.
alex requested changes to this revision.Aug 25 2016, 4:22 AM
alex edited edge metadata.
alex added inline comments.
core/units/visits/visits_tag_processor.php
166

This change isn't covered by test plan.

This revision now requires changes to proceed.Aug 25 2016, 4:22 AM
erik edited the test plan for this revision. (Show Details)Aug 25 2016, 8:43 AM
erik edited edge metadata.
erik requested a review of this revision.Aug 25 2016, 8:46 AM
erik edited edge metadata.
alex accepted this revision.Nov 19 2016, 6:53 AM
alex edited the test plan for this revision. (Show Details)
alex edited edge metadata.
alex edited edge metadata.
This revision is now accepted and ready to land.Nov 19 2016, 6:53 AM
alex updated this revision to Diff 620.Nov 19 2016, 7:06 AM
alex edited the test plan for this revision. (Show Details)
alex edited edge metadata.

Incorporated changes from D223 revision.

alex edited the test plan for this revision. (Show Details)Nov 19 2016, 7:09 AM
This revision was automatically updated to reflect the committed changes.