Unexpected output: Affected paths: relative - resubmit patch.
⚙ D248 INP-1584 - Add readonly mode to "st:ContentBlock" tag
Page MenuHomeIn-Portal Phabricator
Differential D248

INP-1584 - Add readonly mode to "st:ContentBlock" tag
ClosedPublic
Actions

Authored by alex on Oct 18 2016, 6:50 AM.

Details

Reviewers
erik
Commits
rINP16528: Fixes INP-1584 - Add readonly mode to "st:ContentBlock" tag
Test Plan
  1. in Admin Console
    • go to Website & Content → Browse Website section
    • click on Content Mode button in top frame
    • click on orange Edit Content button on 1st content block on the page
    • type some content and press Save button on toolbar
    • confirm, that content is shown
  2. in IDE
    • open /themes/advanced/index.tpl template
    • locate ContentBlock tag, that matches Edit Content button on the page
    • add mode="readonly" attribute to it
  3. in Admin Console
    • reload the page by clicking on Content Mode button in top frame
    • confirm, that editing controls no longer are shown for that content block
    • confirm, that content block data is still shown

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.3.x
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 470
Build 470: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 600.Oct 18 2016, 6:50 AM
alex retitled this revision from to INP-1584 - Add readonly mode to "st:ContentBlock" tag.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1584.
alex edited edge metadata.Oct 18 2016, 7:51 AM
alex added a project: Restricted Project.
erik accepted this revision.Oct 19 2016, 4:08 AM
erik edited edge metadata.
This revision is now accepted and ready to land.Oct 19 2016, 4:08 AM
Closed by commit rINP16528: Fixes INP-1584 - Add readonly mode to "st:ContentBlock" tag (authored by alex). · Explain WhyJan 21 2017, 10:45 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 160016382Oct 18 2016, 6:50 AM
★
★
Diff 269216526rINP16528Jan 21 2017, 10:45 AM
★
★

Diff 600

View Options

core/units/categories/categories_tag_processor.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server