Unexpected output: Affected paths: relative - resubmit patch.
⚙ D254 INP-1591 - Explicitly set 0px top margin for Modal Window iframes
Page MenuHomeIn-Portal Phabricator
  • Changed Files
  • core/admin_templates/js/jquery/thickbox/thickbox.css
Differential D254

INP-1591 - Explicitly set 0px top margin for Modal Window iframes
ClosedPublic
Actions

Authored by alex on Oct 27 2016, 6:27 AM.

Details

Reviewers
erik
Commits
rINP16477: Fixes INP-1591 - Explicitly set 0px top margin for Modal Window iframes
Test Plan
  1. in IDE:
    • open /themes/advanced/platform/inc/styles.css file for editing
    • anywhere add iframe { margin-top: 10px; } style and save changes
  2. in Admin Console
    • go to Website & Content → Browse Website section
    • click on Content Mode button in top frame
    • click on orange Edit Content button
    • confirm, that content of opened modal window is within modal window DIV (see related discussion to understand how it will look if fix isn't working)

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 476
Build 476: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 606.Oct 27 2016, 6:27 AM
alex retitled this revision from to INP-1591 - Explicitly set 0px top margin for Modal Window iframes.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1591.
alex edited edge metadata.Oct 27 2016, 6:28 AM
alex added a project: Restricted Project.
erik accepted this revision.Nov 11 2016, 4:30 AM
erik edited edge metadata.
This revision is now accepted and ready to land.Nov 11 2016, 4:30 AM
Closed by commit rINP16477: Fixes INP-1591 - Explicitly set 0px top margin for Modal Window iframes (authored by alex). · Explain WhyNov 25 2016, 5:05 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 160616388Oct 27 2016, 6:27 AM
★
★
Diff 264316476rINP16477Nov 25 2016, 5:05 AM
★
★

Diff 606

View Options

core/admin_templates/js/jquery/thickbox/thickbox.css

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server