Unexpected output: Affected paths: relative - resubmit patch.
⚙ D255 INP-1593 - Auto-detect format of provided password in "kPasswordFormatter::hashPassword" method for migrated users
Page MenuHomeIn-Portal Phabricator

INP-1593 - Auto-detect format of provided password in "kPasswordFormatter::hashPassword" method for migrated users
ClosedPublic

Authored by alex on Nov 1 2016, 7:56 AM.

Details

Test Plan

Part 1

  1. install In-Portal 5.2.0
  2. login to Admin Console
  3. create regular user
  4. create administrator user
  5. perform login to Front-End using regular user and original password (set upon user creation)
  6. confirm, that login was successfull
  7. perform login to Admin Console using administrator user and original password (set upon user creation)
  8. confirm, that login was successfull

Part 2

  1. upgrade to In-Portal 5.2.x (latest development branch with this patch applied)
  2. confirm, that in Users table in database all created users have 2 in PasswordHashingMethod column
  3. ! backup Users table (this table content at current state will be needed again later) !
  4. perform login to Front-End using regular user and original password (set upon user creation)
  5. confirm, that login was successfull
  6. changing that user password using My Profile page
  7. logout
  8. perform login to Front-End using regular user and changed password
  9. confirm, that login was successfull
  10. try to login to Admin Console using administrator user and original password (set upon user creation)
  11. confirm, that login was successfull
  12. change that user password using link before Logout in top frame
  13. logout
  14. try to login to Admin Console using administrator user and changed password
  15. confirm, that login was successfull

Part 3

  1. restore Users table content from backup
  2. login to Admin Console using root user and whatever password was set during In-Portal 5.2.0 installation
  3. confirm, that login was successfull
  4. go to User ManagementAdministrators section
  5. change regular user and administrator passwords
  6. logout
  7. perform login to Admin Console using administrator user and changed (above) password
  8. confirm, that login was successfull
  9. perform login to Front-End using regular user and changed (above) password
  10. confirm, that login was successfull

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint ErrorsExcuse: Won't be fixing due planned rewrite, when `password_hash` function will be used.
SeverityLocationCodeMessage
Errorcore/kernel/utility/formatters/password_formatter.php:212PHPCS.E.CodingStandard.Formatting.BlankLineBeforeReturn.BlankLineBeforeReturnCodingStandard.Formatting.BlankLineBeforeReturn.BlankLineBeforeReturn
Warningcore/kernel/utility/formatters/password_formatter.php:213PHPCS.W.Squiz.PHP.NonExecutableCode.UnreachableSquiz.PHP.NonExecutableCode.Unreachable
Unit
No Unit Test Coverage
Build Status
Buildable 477
Build 477: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 607.Nov 1 2016, 7:56 AM
alex retitled this revision from to INP-1593 - Auto-detect format of provided password in "kPasswordFormatter::hashPassword" method for migrated users.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1593.
alex edited edge metadata.Nov 1 2016, 7:56 AM
alex added a project: Restricted Project.
erik accepted this revision.Nov 22 2016, 7:43 AM
erik edited edge metadata.
This revision is now accepted and ready to land.Nov 22 2016, 7:43 AM
This revision was automatically updated to reflect the committed changes.