Unexpected output: Affected paths: relative - resubmit patch.
⚙ D259 INP-1630 - Actualize link injection code in "my_link" plugin of CKEditor
Page MenuHomeIn-Portal Phabricator
  • Changed Files
  • core/ckeditor/plugins/my_link/plugin.js

INP-1630 - Actualize link injection code in "my_link" plugin of CKEditor
ClosedPublic

Authored by alex on Nov 15 2016, 11:47 AM.

Details

Test Plan

Actions to test

  • adding internal link into empty editor
  • adding internal link, when text is selected in the editor
  • editing existing internal link and changing internal page it links to
  • adding external link to url with http protocol into empty editor
  • adding external link to url with http protocol, when text is selected in the editor
  • editing existing external link and changing external page it links to, but not protocol
  • adding external link to url with https protocol into empty editor
  • adding external link to url with https protocol, when text is selected in the editor
  • editing existing external link and changing external page it links to, but not protocol

Test plan

  • in Admin Console
    1. go to Website & ContentBrowse Website section
    2. click on Content Mode button in top frame
    3. click on orange Edit Content button
    4. confirm, that window (modal or popup) was opened with CKEditor v4.2+ in it
    5. try all above shown actions (clear editor content before each action test)
    6. close modal window
  • in IDE
    1. open /themes/advanced/index.tpl template
    2. add mode="inline" attribute to the st_ContentBlock tag used in it
  • in Admin Console
    1. click inside dotted area to activate CKEditor
    2. try all above shown actions
    3. click outside of dotted area

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 526
Build 526: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 613.Nov 15 2016, 11:47 AM
alex retitled this revision from to INP-1630 - Actualize link injection code in "my_link" plugin of CKEditor.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1630.
erik requested changes to this revision.Nov 22 2016, 6:28 AM
erik edited edge metadata.

When editing inline block in adm.console, button "Remove Link" is not available, and this makes problematic to input non-linked text after some link is added to empty editor.

This revision now requires changes to proceed.Nov 22 2016, 6:28 AM
erik accepted this revision.Nov 22 2016, 6:37 AM
erik edited edge metadata.

Mentioned above not a bug. Clearing editor area after each step helps to avoid link merging problem.

This revision is now accepted and ready to land.Nov 22 2016, 6:37 AM
alex added a comment.Nov 22 2016, 6:40 AM
In D259#5085, @erik wrote:

When editing inline block in adm.console, button "Remove Link" is not available, and this makes problematic to input non-linked text after some link is added to empty editor.

Most likely described behavior existed prior to this patch and therefore this patch can't be hold responsible for breaking it. Please complete testing process ignoring this issue.

If you think, that this is an error in my_link plugin and all works fine, when you remove my_link plugin from .extraPlugins in CKEditor config, then please file an issue in Confluence.

alex edited the test plan for this revision. (Show Details)Nov 22 2016, 6:50 AM
alex edited edge metadata.
alex added a comment.Nov 22 2016, 6:53 AM
In D259#5085, @erik wrote:

When editing inline block in adm.console, button "Remove Link" is not available, and this makes problematic to input non-linked text after some link is added to empty editor.

After some digging we've found out, that Remove Link button is permanently hidden in CKEditor configuration. Another way to achieve the same functionality is to:

  1. right click on the link to open context menu
  2. select UnLink option
This revision was automatically updated to reflect the committed changes.