Page MenuHomeIn-Portal Phabricator

INP-1582 - Disable "codemirror" CKEditor add-on during inline Content Block editing
ClosedPublic

Authored by alex on Oct 12 2016, 11:13 AM.

Details

Test Plan

Preparations

  1. download SourceDialog plugin from http://ckeditor.com/addon/sourcedialog website
  2. install SourceDialog plugin:
    • download plugin file (zip)
    • unpack downloaded file into /core/ckeditor/plugins/ folder
  3. edit inp_ckconfig.js file (in interface preset or global one, whichever is used) and inside it:
    • add sourcedialog to comma-separated list of plugins in CKEDITOR.config.extraPlugins setting
    • change CKEDITOR.config.toolbar_Inline setting and add 'Sourcedialog' to last array

Test Plan

  1. in IDE:
    • edit index.tpl file (of advanced theme) add mode="inline" to any <inp2:st_ContentBlock tag
  2. in Admin Console:
    • go to Website & ContentBrowse Website section
    • click on Content Mode button in top frame
    • confirm, that content block changed before doesn't have Edit Content orange button, but still have orange dotted frame
    • click inside dotted frame
    • confirm, that inline CKEditor was shown and it has Source button on toolbar
    • click on Source button
    • confirm, that CKEditor style modal window opens with just textarea and OK/Cancel buttons in it
    • type something in textarea and press OK
    • confirm, that inline CKEditor toolbar is still visible and new content appears inside dotted frame

Diff Detail

Repository
rINP In-Portal
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex updated this revision to Diff 598.Oct 12 2016, 11:13 AM
alex retitled this revision from to INP-1582 - Disable "codemirror" CKEditor add-on during inline Content Block editing.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1582.
erik accepted this revision.Oct 13 2016, 4:48 AM
erik edited edge metadata.
This revision is now accepted and ready to land.Oct 13 2016, 4:48 AM
alex edited edge metadata.Oct 14 2016, 8:15 AM
alex added a project: Restricted Project.
This revision was automatically updated to reflect the committed changes.