Differential D254

INP-1591 - Explicitly set 0px top margin for Modal Window iframes
ClosedPublic
Actions

Authored by alex on Oct 27 2016, 6:27 AM.

Tags

Subscribers

None

Details

Reviewers

Commits

rINP16477: Fixes INP-1591 - Explicitly set 0px top margin for Modal Window iframes

Test Plan

in IDE:
- open /themes/advanced/platform/inc/styles.css file for editing
- anywhere add iframe { margin-top: 10px; } style and save changes
in Admin Console
- go to Website & Content → Browse Website section
- click on Content Mode button in top frame
- click on orange Edit Content button
- confirm, that content of opened modal window is within modal window DIV (see related discussion to understand how it will look if fix isn't working)

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex updated this revision to Diff 606.Oct 27 2016, 6:27 AM

alex retitled this revision from to INP-1591 - Explicitly set 0px top margin for Modal Window iframes.

alex updated this object.

alex edited the test plan for this revision. (Show Details)

alex added 1 JIRA issue(s): INP-1591.

Herald added a reviewer: erik. · View Herald TranscriptOct 27 2016, 6:27 AM

alex edited edge metadata.Oct 27 2016, 6:28 AM

alex added a project: Restricted Project.

erik accepted this revision.Nov 11 2016, 4:30 AM

erik edited edge metadata.

This revision is now accepted and ready to land.Nov 11 2016, 4:30 AM

Closed by commit rINP16477: Fixes INP-1591 - Explicitly set 0px top margin for Modal Window iframes (authored by alex). · Explain WhyNov 25 2016, 5:05 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 643

branches/5.2.x/core/admin_templates/js/jquery/thickbox/thickbox.css

Loading...