INP-1656 - Emulate SVG file resize in "ImageHelper"
ClosedPublic
Actions

Authored by alex on Dec 7 2016, 6:38 AM.

Details

Reviewers

erik

Commits

Test Plan

in IDE:
1. open /modules/custom/units/widgets/widgets_config.php file for editing
2. add *.svg to allowed file extensions in Image field declaration and save changes
in Admin Console:
1. go to Custom → Widgets section
2. add 1 record with JPG file (square image with dimensions larger than 120x120) uploaded in Image field
3. add 1 record with SVG file (square image with dimensions larger than 120x120) uploaded in Image field
4. confirm, that for both records image thumbnail is shown and it's dimensions are 120x120
5. open record with JPG file uploaded
6. confirm, that thumbnail in Image field is displayed
7. close record
8. open record with SVG file uploaded
9. confirm, that thumbnail in Image field isn't displayed (as if non-image was uploaded)
10. close record

Repository

rINP In-Portal

Branch

/in-portal/branches/5.2.x

Lint

Lint Errors

Excuse: Not sure how to fix.

Severity	Location	Code	Message
Error	core/units/helpers/image_helper.php:116	PHPCS.E.Generic.Files.LineLength.MaxExceeded	Generic.Files.LineLength.MaxExceeded

Unit

No Unit Test Coverage

Build Status

Buildable 615
Build 615: arc lint + arc unit

alex retitled this revision from to INP-1656 - Emulate SVG file resize in "ImageHelper".

alex updated this object.

alex edited the test plan for this revision. (Show Details)

alex added 1 JIRA issue(s): INP-1656.

erik accepted this revision.Dec 8 2016, 4:51 AM

erik edited edge metadata.

This revision is now accepted and ready to land.Dec 8 2016, 4:51 AM

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	659	16502		Dec 7 2016, 6:37 AM	★	★
Diff 2	767	16555	rINP16556	Jul 16 2017, 7:19 AM	★	★