Unexpected output: Affected paths: relative - resubmit patch.
⚙ D271 INP-1658 - Don't trigger clicks inside click event handler of CMS revision history dropdown
Page MenuHomeIn-Portal Phabricator
Differential D271

INP-1658 - Don't trigger clicks inside click event handler of CMS revision history dropdown
ClosedPublic
Actions

Authored by alex on Dec 22 2016, 5:08 AM.

Details

Reviewers
erik
Commits
rINP16557: Fixes INP-1658 - Don't trigger clicks inside click event handler of CMS…
Test Plan
  1. login to Admin Console
  2. go to Configuration → Website → Advanced section
  3. enable Enable Revision Control for Section Content setting and save changes
  4. go to Website & Content → Browse Website section
  5. click on Content Mode button in top frame
  6. confirm, that CMS toolbar is shown
  7. if orange Editing Draft (pending) text is shown on the toolbar, then press Discard button
  8. confirm, that green Viewing Revision ... text is shown on toolbar
  9. make some changes to the content block on the page:
    • click on Edit Content button
    • change content block data
    • press Save button (in popup/modal window) to save changes
    • confirm, that green Viewing Revision ... text was changed into orange Editing Draft (pending) text
    • press Save button in CMS toolbar
  10. repeat above steps 3 times to populate revision history dropdown
  11. click on History toolbar button in CMS toolbar
  12. confirm, that dropdown with all page revisions (including current revision) will appear
  13. click on any revision (the link part)
  14. confirm, that selected revision was shown almost immediately (no visible delay)
  15. click on any revision (the non-link link part)
  16. confirm, that selected revision was shown almost immediately (no visible delay)

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 619
Build 619: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 663.Dec 22 2016, 5:08 AM
alex retitled this revision from to INP-1658 - Don't trigger clicks inside click event handler of CMS revision history dropdown.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1658.
erik accepted this revision.Dec 23 2016, 4:07 AM
erik edited edge metadata.
This revision is now accepted and ready to land.Dec 23 2016, 4:07 AM
alex edited edge metadata.Dec 28 2016, 9:14 AM
alex added a project: Restricted Project.
Closed by commit rINP16557: Fixes INP-1658 - Don't trigger clicks inside click event handler of CMS… (authored by alex). · Explain WhyJul 16 2017, 7:29 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 166316502Dec 22 2016, 5:08 AM
★
★
Diff 276816556rINP16557Jul 16 2017, 7:29 AM
★
★

Diff 663

View Options

core/admin_templates/js/template_manager.js

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server