Unexpected output: Affected paths: relative - resubmit patch.
⚙ D280 INP-1663 - Register missing classes in class factory V2
Page MenuHomeIn-Portal Phabricator

INP-1663 - Register missing classes in class factory V2
ClosedPublic

Authored by alex on Jan 7 2017, 5:04 AM.

Details

Test Plan
  1. copy over /index.php into /autoloading_test.php
  2. in /autoloading_test.php file: replace all code that comes after $application->Init(); line with:
$column_set = new ColumnSet(array(
    'order' => array(),
    'hidden_fields' => array(),
    'titles' => array(),
    'widths' => array(),
));
$ckeditor = new CKEditor();
  1. open /autoloading_test.php file from CLI or Web
  2. confirm, that class instances were created and no error happened

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint ErrorsExcuse: The array-specific CS fixes will be done in 5.3.x.
SeverityLocationCodeMessage
Errorcore/units/helpers/helpers_config.php:32PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeywordCodingStandard.Array.Array.SpaceAfterKeyword
Errorcore/units/helpers/helpers_config.php:32PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/helpers/helpers_config.php:33PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeywordCodingStandard.Array.Array.SpaceAfterKeyword
Errorcore/units/helpers/helpers_config.php:33PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/helpers/helpers_config.php:34PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeywordCodingStandard.Array.Array.SpaceAfterKeyword
Errorcore/units/helpers/helpers_config.php:34PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Unit
No Unit Test Coverage
Build Status
Buildable 642
Build 642: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 676.Jan 7 2017, 5:04 AM
alex retitled this revision from to INP-1663 - Register missing classes in class factory V2.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1663.
alex edited the test plan for this revision. (Show Details)Jan 7 2017, 5:13 AM
alex edited edge metadata.
erik accepted this revision.Jan 13 2017, 4:32 AM
erik edited edge metadata.
This revision is now accepted and ready to land.Jan 13 2017, 4:32 AM
This revision was automatically updated to reflect the committed changes.