Unexpected output: Affected paths: relative - resubmit patch.
⚙ D285 INP-1670 - Check for empty/null value in "UserHelper::getGroupsWithIPRestrictions" method
Page MenuHomeIn-Portal Phabricator

INP-1670 - Check for empty/null value in "UserHelper::getGroupsWithIPRestrictions" method
ClosedPublic

Authored by alex on Feb 7 2017, 2:35 PM.

Details

Test Plan
NOTE: Perform tests with Debug Mode turned "on" and "off".

Preparations

  1. login to Admin Console as root
  2. go to User ManagementAdministrators section
  3. create administrator

Part 1

  • in Database:
    1. set IPRestrictions column for admin user group to NULL
  • in Admin Console:
    1. login to Admin Console using above created administrator account
    2. confirm, that login was successful

Part 2

  • in Database:
    1. set IPRestrictions column for admin user group to an empty string
  • in Admin Console:
    1. login to Admin Console using above created administrator account
    2. confirm, that login was successful

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 679
Build 679: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 701.Feb 7 2017, 2:35 PM
alex retitled this revision from to INP-1670 - Check for empty/null value in "UserHelper::getGroupsWithIPRestrictions" method.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1670.
erik accepted this revision.Mar 30 2017, 1:15 PM
erik edited edge metadata.
This revision is now accepted and ready to land.Mar 30 2017, 1:15 PM
alex edited edge metadata.Mar 31 2017, 6:04 AM
alex added a project: Restricted Project.
This revision was automatically updated to reflect the committed changes.