Differential D286

INP-1680 - Restore behavior of "Select All" checkbox in "grid_multioptions_filter" grid filter
ClosedPublic
Actions

Authored by alex on Feb 13 2017, 6:07 AM.

Details

Reviewers

erik

Commits

rINP16551: Fixes INP-1680 - Restore behavior of "Select All" checkbox in…

Test Plan

login to Admin Console
go to Website & Content → Labels & Phrases section
click on Open Filter input in Location column filter
case 1:
- check Front and Both checkboxes
- confirm, that Select All and Admin checkboxes are unchecked
case 2:
- check Admin checkbox
- confirm, that Select All checkbox became checked
case 3:
- press Search button below the filter
- click on Open Filter input in Location column filter
case 4:
- uncheck Select All checkbox
- confirm, that Front, Admin and Both checkboxes became unchecked
case 5:
- press Search button below the filter
- click on Open Filter input in Location column filter
- confirm, that Select All, Front, Admin and Both checkboxes stayed unchecked

Diff Detail

Repository

rINP In-Portal

Branch

/in-portal/branches/5.2.x

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 680
Build 680: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 702.Feb 13 2017, 6:07 AM

alex retitled this revision from to INP-1680 - Restore behavior of "Select All" checkbox in "grid_multioptions_filter" grid filter.

alex updated this object.

alex edited the test plan for this revision. (Show Details)

alex added 1 JIRA issue(s): INP-1680.

Herald added a reviewer: erik. · View Herald TranscriptFeb 13 2017, 6:07 AM

alex edited edge metadata.Feb 13 2017, 6:11 AM

alex added a project: Restricted Project.

erik accepted this revision.Apr 5 2017, 5:33 AM

erik edited edge metadata.

This revision is now accepted and ready to land.Apr 5 2017, 5:33 AM

Closed by commit rINP16551: Fixes INP-1680 - Restore behavior of "Select All" checkbox in… (authored by alex). · Explain WhyJul 4 2017, 6:31 AM

This revision was automatically updated to reflect the committed changes.

alex added a child revision: D315: INP-1712 - Trigger "change" event, when checkbox value is changed by script.Jul 16 2017, 6:29 AM

Revision Contents
Changeset List

			Path	Packages
M			core/admin_templates/js/grid_filters.js (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	702	16532		Feb 13 2017, 6:07 AM	★	★
Diff 2	754	16545	rINP16551	Jul 4 2017, 6:31 AM	★	★

Commit	Parents	Author	Summary	Date
#fake-hash			Ignore it :) (Show More…)

	Status	Author	Revision
	Closed	alex	D315 INP-1712 - Trigger "change" event, when checkbox value is changed by script
	Closed	alex	D286 INP-1680 - Restore behavior of "Select All" checkbox in "grid_multioptions_filter" grid filter

Diff 702

View Options

core/admin_templates/js/grid_filters.js

INP-1680 - Restore behavior of "Select All" checkbox in "grid_multioptions_filter" grid filterClosedPublicActions