Unexpected output: Affected paths: relative - resubmit patch.
⚙ D290 INP-1684 - Ignore hidden columns during grid column width saving
Page MenuHomeIn-Portal Phabricator
Differential D290

INP-1684 - Ignore hidden columns during grid column width saving
ClosedPublic
Actions

Authored by alex on Mar 2 2017, 8:58 AM.

Details

Reviewers
erik
Commits
rINP16566: Fixes INP-1684 - Ignore hidden columns during grid column width saving
Test Plan
  • in IDE:
    1. open /core/units/phrases/phrases_config.php for editing
    2. for Phrases grid move Module column to the end (before CurrentColumnTranslation column)
  • in database:
    1. execute TRUNCATE TABLE inp_UserPersistentSessionData; query (replace inp_ with used table prefix)
  • in Admin Console:
    1. go to Website & Content → Labels & Phrases section
    2. confirm, that Module column is displayed at last position
    3. resize Module column by a visible margin (so that you can immediately see if column width is custom)
    4. wait 2 seconds for AJAX request to happen, that saves new column width
    5. reload the page
    6. confirm, that Module column width remained the same

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 691
Build 691: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 712.Mar 2 2017, 8:58 AM
alex retitled this revision from to INP-1684 - Ignore hidden columns during grid column width saving.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1684.
alex edited the test plan for this revision. (Show Details)Mar 2 2017, 8:59 AM
alex edited edge metadata.
alex added a project: Restricted Project.
erik accepted this revision.Apr 5 2017, 5:19 AM
erik edited edge metadata.
This revision is now accepted and ready to land.Apr 5 2017, 5:19 AM
Closed by commit rINP16566: Fixes INP-1684 - Ignore hidden columns during grid column width saving (authored by alex). · Explain WhyJul 16 2017, 12:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 171216532Mar 2 2017, 8:58 AM
★
★
Diff 277716565rINP16566Jul 16 2017, 12:49 PM
★
★

Diff 712

View Options

core/units/helpers/col_picker_helper.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server