Page MenuHomeIn-Portal Phabricator

INP-1694 - Upgrade YUICompressor to v2.4.8
ClosedPublic

Authored by alex on Apr 29 2017, 6:01 AM.

Details

Test Plan

Preparations

  • in IDE:
    1. create /themes/advanced/compress_fixture.css file with this content:
@media screen and (min-width: 480px) and (max-width: 639px) {
    body {
        background-color: red;
    }
}

@media screen and (max-width: 640px) {
    body {
        background-color: green;
    }
}
  1. create /themes/advanced/compress_fixture.tpl file with this content:
<!DOCTYPE html>
<html lang="en">
<head>
    <meta charset="UTF-8">
    <title>Title</title>

    <link rel="stylesheet" rev="stylesheet" href="<inp2:m_Compress files='compress_fixture.css'/>" type="text/css" />
</head>
<body>

</body>
</html>
    1. in /system/config.php change CompressionEngine setting value to yui
  • in Admin Console:
    1. go to ConfigurationWebsiteThemes section
    2. press Rescan Themes button on toolbar

Part 1

NOTE: Test with both Debug Mode enabled and disabled.
  • on Front-End:
    1. open this URL: .../compress_fixture.html (replace ... with base url of your In-Portal installation)
    2. resize window to be smaller than 640px in width
    3. confirm, that window background color is green

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint ErrorsExcuse: Not fixing, because would ungergo total rewrite later.
SeverityLocationCodeMessage
Errorcore/units/helpers/minifiers/minify_helper.php:234PHPCS.E.Generic.Files.LineLength.MaxExceededGeneric.Files.LineLength.MaxExceeded
Unit
No Unit Test Coverage
Build Status
Buildable 719
Build 719: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 733.Apr 29 2017, 6:01 AM
alex retitled this revision from to INP-1694 - Upgrade YUICompressor to v2.4.8.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1694.
alex edited the test plan for this revision. (Show Details)Apr 29 2017, 6:16 AM
alex edited edge metadata.
erik accepted this revision.May 17 2017, 10:22 AM
erik edited edge metadata.
This revision is now accepted and ready to land.May 17 2017, 10:22 AM
This revision was automatically updated to reflect the committed changes.