Differential D332

INP-1732 Create user session, when search is performed
ClosedPublic
Actions

Authored by glebs on Feb 6 2018, 9:55 AM.

Details

Reviewers

erik

Commits

rINP16621: Fixes INP-1732 - Create user session, when search is performed

Test Plan

NOTE: Use advanced theme for testing.

Go to frontend and perform a search
In any mysql client (phpmyadmin or PhpStorm) check Search table (e.g. "inp_ses_932492397_inp_Search") is created
In any mysql client (phpmyadmin or PhpStorm) run SQL to expire session like

UPDATE UserSessions SET LastAccessed = 0 WHERE SessionKey = 932492397

Where 932492397 - number from search table name

Go to admin Configuration → Website → Scheduled Task
Check delete_expired_sessions task and click on Run button in toolbar
In any mysql client (phpMyAdmin or PhpStorm) confirm temp Search table dropped

Diff Detail

Repository

rINP In-Portal

Branch

/in-portal/branches/5.2.x

Lint

Lint Errors

Excuse: Looks ok

Severity	Location	Code	Message
Error	core/units/categories/categories_event_handler.php:2801	PHPCS.E.Generic.WhiteSpace.ScopeIndent.IncorrectExact	Generic.WhiteSpace.ScopeIndent.IncorrectExact

Unit

No Unit Test Coverage

Build Status

Buildable 826
Build 826: arc lint + arc unit

Event Timeline

glebs created this revision.Feb 6 2018, 9:55 AM

Herald added a reviewer: alex. · View Herald TranscriptFeb 6 2018, 9:55 AM

Sorry, don't know how to test by user

The problem described in Confluence discussion from connected JIRA task is that session isn't created, when search is performed by guest and therefore search tables created are never are deleted by session expiration script. According to that you need to test, that prior to this change no sessions are created, but after patch is applied sessions are created AND search tables gets removed by session expiration code.

This revision now requires changes to proceed.Feb 6 2018, 10:05 AM

glebs requested review of this revision.Feb 7 2018, 6:39 AM

glebs edited the test plan for this revision. (Show Details)

glebs edited edge metadata.

alex edited the test plan for this revision. (Show Details)Feb 7 2018, 8:13 AM

alex edited reviewers, added: erik; removed: alex.

erik accepted this revision.Feb 8 2018, 5:28 AM

This revision is now accepted and ready to land.Feb 8 2018, 5:28 AM

Closed by commit rINP16621: Fixes INP-1732 - Create user session, when search is performed (authored by alex). · Explain WhyApr 6 2018, 9:17 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	824	16600		Feb 6 2018, 9:55 AM	★	★
Diff 2	841	16620	rINP16621	Apr 6 2018, 9:17 AM	★	★

Commit	Parents	Author	Summary	Date
#fake-hash			Ignore it :) (Show More…)

Diff 824

View Options

core/kernel/db/cat_event_handler.php