Differential D342

INP-1742 Apply "ItemType" filter in JOIN to Search Results table
ClosedPublic
Actions

Authored by glebs on Apr 26 2018, 6:26 AM.

Details

Reviewers

erik

Commits

rINP16671: Fixes INP-1742 - Apply "ItemType" filter in JOIN to Search Results table

Test Plan

NOTE: Test with enables In-Link module

Create new category and new link with same word in titles in admin
Search for this word and confirm both found
In DB directly set category ResourseId equals to link's ResourseId
Search by some word that exists only in category title
Confirm there is no link in search results
Search by some word that exists only in link title
Confirm there is no category in search results

Diff Detail

Repository

rINP In-Portal

Branch

/in-portal/branches/5.2.x

Lint

Lint Errors

Excuse: Looks ok

Severity	Location	Code	Message
Error	core/units/categories/categories_event_handler.php:383	PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeyword	CodingStandard.Array.Array.SpaceAfterKeyword
Error	core/units/categories/categories_event_handler.php:383	PHPCS.E.Generic.PHP.LowerCaseKeyword.Found	Generic.PHP.LowerCaseKeyword.Found

Unit

No Unit Test Coverage

Build Status

Buildable 872
Build 872: arc lint + arc unit

Event Timeline

glebs created this revision.Apr 26 2018, 6:26 AM

Herald added a reviewer: alex. · View Herald TranscriptApr 26 2018, 6:27 AM

alex added a project: Restricted Project.Apr 26 2018, 9:20 AM

alex added inline comments.

core/units/categories/categories_event_handler.php
383	How it is possible, that CS issues were reported on a line, that doesn't have them?

glebs edited the test plan for this revision. (Show Details)Apr 26 2018, 10:37 AM

glebs edited reviewers, added: erik; removed: alex.

erik accepted this revision.Apr 26 2018, 10:56 AM

This revision is now accepted and ready to land.Apr 26 2018, 10:56 AM

alex edited the test plan for this revision. (Show Details)Apr 26 2018, 11:10 AM

This revision was landed with ongoing or failed builds.Feb 9 2021, 3:00 AM

Closed by commit rINP16671: Fixes INP-1742 - Apply "ItemType" filter in JOIN to Search Results table (authored by alex, committed by ). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	852	16632		Apr 26 2018, 6:26 AM	★	★
Diff 2	981	16670	rINP16671	Feb 9 2021, 3:00 AM	★	★

Commit	Parents	Author	Summary	Date
#fake-hash			Ignore it :) (Show More…)

Diff 852

View Options

core/kernel/db/cat_event_handler.php