Made batch deleting in place of individual ones
Details
Details
- Reviewers
alex
- go to Admin Console (login if needed)
- go to Configuration → Website → Advanced section
- ensure, that Enable SEO-friendly URLs mode (MOD-REWRITE) setting is enabled
- go to Front-End and visit 2 (or more) pages
- confirm that CachedUrls database table has records added, related to visited pages
- go to Admin Console (login if needed)
- go to Tools → System Tools section
- press Reset button in the Config Files → Reset Configs Files Cache and Parsed System Data subsection
- press Refresh button in the Templates → Refresh Theme Files subsection
- confirm that records in the CachedUrls database table have Hash values equals to 0 and empty Url values
- on the Front-End visit one more page
- go to Admin Console (login if needed)
- go to Configuration → Website → Scheduled Tasks section
- run delete_expired_cached_urls scheduled task
- confirm, that:
- records with Hash values set to 0 were deleted from CachedUrls database table
- records with other Hash values were not deleted from CachedUrls database table
Diff Detail
Diff Detail
- Repository
- rINP In-Portal
- Branch
- /in-portal/branches/5.2.x
- Lint
Lint Errors Excuse: full file fe-formatting is not part of ths task, event method name may start with capital letter Severity Location Code Message Error core/units/admin/admin_config.php:32 PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeyword CodingStandard.Arrays.Array.SpaceAfterKeyword Error core/units/admin/admin_config.php:32 PHPCS.E.Generic.PHP.LowerCaseKeyword.Found Generic.PHP.LowerCaseKeyword.Found Error core/units/admin/admin_events_handler.php:1176 PHPCS.E.CodingStandard.NamingConventions.ValidFunctionName.ScopeNotCamelCaps CodingStandard.NamingConventions.ValidFunctionName.ScopeNotCamelCaps - Unit
No Unit Test Coverage - Build Status
Buildable 913 Build 913: arc lint + arc unit
Event Timeline
| core/kernel/managers/cache_manager.php | ||
|---|---|---|
| 806 | Test plan doesn't cover asserting that Url field is also empty. | |
| core/units/admin/admin_config.php | ||
| 33 | Update test plan to perform unit config cache reset. After patch is applied the scheduled task won't be registered by itself. | |
| core/units/admin/admin_events_handler.php | ||
| 1178 | SQL isn't formatted correctly. | |
| core/units/admin/admin_events_handler.php | ||
|---|---|---|
| 1178–1179 | For DELETE statements the DELETE FROM TableName part goes on 1st line. | |