Differential D357

INP-1761 - Account for LeftJoinOptimizer during grid total calculation
ClosedPublic
Actions

Authored by alex on Mar 21 2019, 4:58 AM.

Tags

Subscribers

None

Details

Reviewers

Commits

rINP16663: Fixes INP-1761 - Account for LeftJoinOptimizer during grid total calculation

Test Plan

in IDE:
1. open core/admin_templates/catalog_tab.tpl file for editing
2. add totals_render_as="grid_total_row" attribute to the <inp2:m_RenderElement name="grid_js" ... tag call
3. save changes
4. open core/units/categories/categories_config.php file for editing
5. add 'ThumbPath' => Array ('filter_block' => 'grid_like_filter', 'totals' => 'SUM'), to the Fields array of Default grid
6. save changes
in Admin Console
1. login to Admin Console
2. go to Website & Content → Structure & Data section
3. click on Sections tab
4. confirm, that:
  - categories/sections grid is displayed correctly
  - there is new column for ThumbPath and it has 0 as total value below it

Diff Detail

Repository

Branch

/in-portal/branches/5.2.x

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 916
Build 916: arc lint + arc unit

Event Timeline

alex created this revision.Mar 21 2019, 4:58 AM

Herald added a reviewer: erik. · View Herald TranscriptMar 21 2019, 4:58 AM

alex requested review of this revision.Mar 21 2019, 4:58 AM

Harbormaster completed remote builds in B916: Diff 893.Mar 21 2019, 4:58 AM

alex added a project: Restricted Project.Mar 21 2019, 4:58 AM

erik accepted this revision.Mar 27 2019, 5:16 AM

This revision is now accepted and ready to land.Mar 27 2019, 5:16 AM

Closed by commit rINP16663: Fixes INP-1761 - Account for LeftJoinOptimizer during grid total calculation (authored by alex, committed by ). · Explain WhyJan 11 2021, 2:38 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 893

core/kernel/db/dblist.php

Loading...